From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-16860-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 19423 invoked by alias); 20 Oct 2010 01:32:17 -0000
Received: (qmail 19413 invoked by uid 22791); 20 Oct 2010 01:32:17 -0000
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=ALL_TRUSTED,AWL,BAYES_00,MISSING_MID,NORMAL_HTTP_TO_IP
X-Spam-Check-By: sourceware.org
Received: from localhost (HELO sourceware.org) (127.0.0.1)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 20 Oct 2010 01:32:13 +0000
From: "jistone at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: systemtap@sources.redhat.com
Subject: [Bug translator/12138] sdt_misc.exp fails most ptr types on i686
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: systemtap
X-Bugzilla-Component: translator
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jistone at redhat dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: systemtap at sources dot redhat.com
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Changed-Fields:
In-Reply-To: <bug-12138-1110@http.sourceware.org/bugzilla/>
References: <bug-12138-1110@http.sourceware.org/bugzilla/>
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date: Wed, 20 Oct 2010 01:32:00 -0000
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
X-SW-Source: 2010-q4/txt/msg00059.txt.bz2
Message-ID: <20101020013200.NRtLI1Giy17wy8Bo_0ESeW8jOtpAJVl9fqg00_-nO64@z>

http://sourceware.org/bugzilla/show_bug.cgi?id=12138

--- Comment #3 from Josh Stone <jistone at redhat dot com> 2010-10-20 01:32:09 UTC ---
(In reply to comment #1)
> The test isn't very helpful about diagnostics, but I'll pick the first FAIL:
> 
> From sdt_types.c:
>   char *ptr_char_var = &char_var;
>   STAP_PROBE2(provider,ptr_char_var,ptr_char_var,&char_var);

Roland helped me figure out that .note.stapsdt gets:
.asciz "ptr_char_var"
.asciz "4@124(%esp) 4@%eax"

> printf("%p %p\n", $arg1, $arg2)

The translator does:
$arg1: user_int((%{ /* unprivileged */ /* pure */u_fetch_register(4) %}) +
(124))
$arg2: %{ /* unprivileged */ /* pure */u_fetch_register(0) %}

So the trip through user_int() extends the sign.  We could add user_uint(), if
there's enough info for the SDT-translator to know it should be unsigned.  I
think that's indicated by "4@..." instead of "-4@..."?

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.