From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2442 invoked by alias); 21 Apr 2011 17:18:46 -0000 Received: (qmail 2433 invoked by uid 22791); 21 Apr 2011 17:18:45 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,MAY_BE_FORGED,TW_JL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from e37.co.us.ibm.com (HELO e37.co.us.ibm.com) (32.97.110.158) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Apr 2011 17:18:28 +0000 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e37.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p3LHFTTt023801 for ; Thu, 21 Apr 2011 11:15:29 -0600 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p3LHJB82088674 for ; Thu, 21 Apr 2011 11:19:11 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p3LHI7h3026730 for ; Thu, 21 Apr 2011 11:18:13 -0600 Received: from linux.vnet.ibm.com (srdronam.in.ibm.com [9.124.31.43] (may be forged)) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id p3LHI1rU026088; Thu, 21 Apr 2011 11:18:02 -0600 Date: Thu, 21 Apr 2011 17:18:00 -0000 From: Srikar Dronamraju To: Peter Zijlstra Cc: Ingo Molnar , Steven Rostedt , Linux-mm , Arnaldo Carvalho de Melo , Linus Torvalds , Jonathan Corbet , Christoph Hellwig , Masami Hiramatsu , Thomas Gleixner , Ananth N Mavinakayanahalli , Oleg Nesterov , LKML , SystemTap , Jim Keniston , Roland McGrath , Andi Kleen , Andrew Morton Subject: Re: [PATCH v3 2.6.39-rc1-tip 15/26] 15: uprobes: Handing int3 and singlestep exception. Message-ID: <20110421170355.GH10698@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <20110401143223.15455.19844.sendpatchset@localhost6.localdomain6> <20110401143527.15455.32854.sendpatchset@localhost6.localdomain6> <1303220359.8345.1.camel@twins> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <1303220359.8345.1.camel@twins> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2011-q2/txt/msg00138.txt.bz2 * Peter Zijlstra [2011-04-19 15:39:19]: > On Fri, 2011-04-01 at 20:05 +0530, Srikar Dronamraju wrote: > > + probept = uprobes_get_bkpt_addr(regs); > > + down_read(&mm->mmap_sem); > > + for (vma = mm->mmap; vma; vma = vma->vm_next) { > > + if (!valid_vma(vma)) > > + continue; > > + if (probept < vma->vm_start || probept > vma->vm_end) > > + continue; > > + u = find_uprobe(vma->vm_file->f_mapping->host, > > + probept - vma->vm_start); > > + break; > > + } > > Why the linear vma walk? Surely the find_vma() suffices since there can > only be one vma that matches a particular vaddr. Agree, will incorporate. -- Thanks and Regards Srikar > > > + up_read(&mm->mmap_sem);