public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mjw@redhat.com>
To: "Turgis, Frederic" <f-turgis@ti.com>
Cc: SystemTap <systemtap@sourceware.org>
Subject: Re: "module privilege check" breaks (cross-)compilation due to libelf dependency
Date: Mon, 05 Dec 2011 14:09:00 -0000	[thread overview]
Message-ID: <20111205135825.GF16831@hermans.wildebeest.org> (raw)
In-Reply-To: <28BE1A38672C8B4481BB423D0FD1F22E01BC1426@DNCE03.ent.ti.com>

On Mon, Dec 05, 2011 at 01:36:01PM +0000, Turgis, Frederic wrote:
> Commit "bb4470cacb3f7ce5161f9e8a1b7c37a87516a6c3 PR 13128: Implement
> module privilege check in staprun." has broken my cross-compilation
> environment to build "staprun" tool for ARM android (I do 4 first steps
> on host, staprun step on target), see end of mail.
>
> Having a deeper look, there is in fact code in staprun_funcs.c that
> requires libelf like find_section_in_module() and
> get_module_required_credentials() (Elf_Scn for example) and that is
> not surrounded by HAVE_LIBELF_H or HAVE_ELF_GETSHDRSTRNDX

I had something similar a few days ago, though I don't remember exactly
which setup it was on. Does the following commit help in your case?

commit fa2418539b4ac2cb1352948f68da08890cec7774
Author: Mark Wielaard <mjw@redhat.com>
Date:   Sat Nov 26 02:33:01 2011 +0100

  Fix build error in staprun_funcs.c when HAVE_ELF_GETSHDRSTRNDX is not set.
  
  Mark find_section_in_module arguments unused when HAVE_ELF_GETSHDRSTRNDX
  isn't set.

Or do you need more than that?

Cheers,

Mark

  reply	other threads:[~2011-12-05 13:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-05 13:58 Turgis, Frederic
2011-12-05 14:09 ` Mark Wielaard [this message]
2011-12-05 16:13   ` Turgis, Frederic
2011-12-05 17:38     ` Dave Brolley
2011-12-06  8:40       ` Turgis, Frederic
2011-12-07  9:30         ` Dave Brolley
2011-12-07 11:20           ` Turgis, Frederic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111205135825.GF16831@hermans.wildebeest.org \
    --to=mjw@redhat.com \
    --cc=f-turgis@ti.com \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).