From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27259 invoked by alias); 5 Dec 2011 13:58:46 -0000 Received: (qmail 27249 invoked by uid 22791); 5 Dec 2011 13:58:45 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Dec 2011 13:58:28 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pB5DwS7f018755 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 5 Dec 2011 08:58:28 -0500 Received: from hermans.wildebeest.org (ovpn-113-87.phx2.redhat.com [10.3.113.87]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pB5DwQet025671 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 5 Dec 2011 08:58:27 -0500 Received: by hermans.wildebeest.org (Postfix, from userid 500) id 151E1340059; Mon, 5 Dec 2011 14:58:26 +0100 (CET) Date: Mon, 05 Dec 2011 14:09:00 -0000 From: Mark Wielaard To: "Turgis, Frederic" Cc: SystemTap Subject: Re: "module privilege check" breaks (cross-)compilation due to libelf dependency Message-ID: <20111205135825.GF16831@hermans.wildebeest.org> References: <28BE1A38672C8B4481BB423D0FD1F22E01BC1426@DNCE03.ent.ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <28BE1A38672C8B4481BB423D0FD1F22E01BC1426@DNCE03.ent.ti.com> User-Agent: Mutt/1.5.21 (2010-09-15) Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2011-q4/txt/msg00291.txt.bz2 On Mon, Dec 05, 2011 at 01:36:01PM +0000, Turgis, Frederic wrote: > Commit "bb4470cacb3f7ce5161f9e8a1b7c37a87516a6c3 PR 13128: Implement > module privilege check in staprun." has broken my cross-compilation > environment to build "staprun" tool for ARM android (I do 4 first steps > on host, staprun step on target), see end of mail. > > Having a deeper look, there is in fact code in staprun_funcs.c that > requires libelf like find_section_in_module() and > get_module_required_credentials() (Elf_Scn for example) and that is > not surrounded by HAVE_LIBELF_H or HAVE_ELF_GETSHDRSTRNDX I had something similar a few days ago, though I don't remember exactly which setup it was on. Does the following commit help in your case? commit fa2418539b4ac2cb1352948f68da08890cec7774 Author: Mark Wielaard Date: Sat Nov 26 02:33:01 2011 +0100 Fix build error in staprun_funcs.c when HAVE_ELF_GETSHDRSTRNDX is not set. Mark find_section_in_module arguments unused when HAVE_ELF_GETSHDRSTRNDX isn't set. Or do you need more than that? Cheers, Mark