From: Mark Wielaard <mjw@redhat.com>
To: David Smith <dsmith@redhat.com>
Cc: systemtap@sourceware.org, Frank Eigler <fche@redhat.com>
Subject: Re: [SCM] systemtap: system-wide probe/trace tool branch, master, updated. release-1.6-594-g12aa5f9
Date: Fri, 16 Dec 2011 19:01:00 -0000 [thread overview]
Message-ID: <20111216183254.GB2526@toonder.wildebeest.org> (raw)
In-Reply-To: <4EE8C696.7000807@redhat.com>
On Wed, Dec 14, 2011 at 09:53:58AM -0600, David Smith wrote:
> On 12/14/2011 03:42 AM, Mark Wielaard wrote:
>
> > On Tue, 2011-12-13 at 22:32 +0000, fche@sourceware.org wrote:
>
> ...
>
> >> entry = (struct __stp_tf_vma_entry *) _stp_kmalloc_gfp(size,
> >> - STP_ALLOC_SLEEP_FLAGS);
> >> + STP_ALLOC_FLAGS);
> >
> > Urgh that hurts. Especially on memory constraint systems having to do
> > non-sleeping allocations. Isn't there any way we can prevent this? Or at
> > least detect that we are using a task_finder that doesn't notify us in
> > user context? I think there are other places that assume the task_finder
> > only notifies us about updates in user context, for example so we can
> > check the build-id. Having a taks_finder that only operates in atomic
> > contexts is pretty limiting.
>
>
> We could postpone the pain a bit by changing the above to:
>
> #ifdef CONFIG_UTRACE
> entry = (struct __stp_tf_vma_entry *) _stp_kmalloc_gfp(size,
> STP_ALLOC_SLEEP_FLAGS);
> #else
> entry = (struct __stp_tf_vma_entry *) _stp_kmalloc_gfp(size,
> STP_ALLOC_FLAGS);
> #endif
>
> This way only systems using the new code use the non-sleepable alloc.
That seems a nice compromise. I pushed that change. Commit efe1470.
Thanks,
Mark
prev parent reply other threads:[~2011-12-16 18:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111213223224.10508.qmail@sourceware.org>
2011-12-14 11:24 ` Mark Wielaard
2011-12-14 18:03 ` David Smith
2011-12-16 19:01 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111216183254.GB2526@toonder.wildebeest.org \
--to=mjw@redhat.com \
--cc=dsmith@redhat.com \
--cc=fche@redhat.com \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).