From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6578 invoked by alias); 25 Dec 2011 20:20:48 -0000 Received: (qmail 6569 invoked by uid 22791); 25 Dec 2011 20:20:47 -0000 X-SWARE-Spam-Status: No, hits=-1.2 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (80.101.103.228) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 25 Dec 2011 20:20:32 +0000 Date: Sun, 25 Dec 2011 23:59:00 -0000 From: Mark Wielaard To: Adrien Kunysz Cc: Josh Stone , contemplating zombie , systemtap@sourceware.org Subject: Re: Puzzling output of stp script Message-ID: <20111225202026.GB3980@toonder.wildebeest.org> References: <4EF6BAEB.7000006@redhat.com> <20111225110952.GD17069@chouffe> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20111225110952.GD17069@chouffe> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -2.9 (--) Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2011-q4/txt/msg00426.txt.bz2 On Sun, Dec 25, 2011 at 11:09:52AM +0000, Adrien Kunysz wrote: > And that particular example was already fixed a while ago btw: > http://sourceware.org/git/gitweb.cgi?p=systemtap.git;a=commitdiff;h=396afcee5ada2d207b7a6691d4b7ce473e7b2a65 But it was still used in at least two places, the tutorial and beginner's guide, without the .call modifier. Fixed those too and added Josh's suggestion as an exercise: commit 2e96e9163d84fe9772def0318216a6d6da1332a2 Author: Mark Wielaard Date: Sun Dec 25 20:56:53 2011 +0100 Use function.call and function.return in all thread_indent() examples. If the .call modifier isn't used the function probes will match both .call and .inline, but .return doesn't match any inlined functions leading to unbalanced thread_indent output. Cheers, Mark