From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6135 invoked by alias); 19 Jan 2012 13:10:24 -0000 Received: (qmail 6021 invoked by uid 22791); 19 Jan 2012 13:10:23 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-4.hut.fi (HELO smtp-4.hut.fi) (130.233.228.94) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 Jan 2012 13:10:08 +0000 Received: from localhost (katosiko.hut.fi [130.233.228.115]) by smtp-4.hut.fi (8.13.6/8.12.10) with ESMTP id q0JDA652017359 for ; Thu, 19 Jan 2012 15:10:06 +0200 Received: from smtp-4.hut.fi ([130.233.228.94]) by localhost (katosiko.hut.fi [130.233.228.115]) (amavisd-new, port 10024) with LMTP id 22779-1338 for ; Thu, 19 Jan 2012 15:10:06 +0200 (EET) Received: from kosh.localdomain (kosh.hut.fi [130.233.228.12]) by smtp-4.hut.fi (8.13.6/8.12.10) with ESMTP id q0JDA3vt017353 for ; Thu, 19 Jan 2012 15:10:04 +0200 Received: by kosh.localdomain (Postfix, from userid 43888) id C6E7D38C1; Thu, 19 Jan 2012 15:10:03 +0200 (EET) Date: Thu, 19 Jan 2012 13:10:00 -0000 From: Sami Liedes To: systemtap@sourceware.org Subject: Re: automated way to find functions that we might want to blacklist Message-ID: <20120119131003.GC26534@sli.dy.fi> Mail-Followup-To: systemtap@sourceware.org References: <84bor03ij9.fsf@sauna.l.org> <20111223211030.GA23631@sli.dy.fi> <20120115214402.GG6309@sli.dy.fi> <4F15D792.2050408@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3XA6nns4nE4KvaS/" Content-Disposition: inline In-Reply-To: <4F15D792.2050408@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TKK-Virus-Scanned: by amavisd-new-2.1.2-hutcc at katosiko.hut.fi X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2012-q1/txt/msg00022.txt.bz2 --3XA6nns4nE4KvaS/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 856 On Tue, Jan 17, 2012 at 02:18:26PM -0600, David Smith wrote: > A couple of these don't make any sense to me: >=20 > > * hash_64 > > * hash_ptr >=20 > There is nothing that those 2 functions do that can crash the kernel. > Those functions (should be) always inlined. I'd guess the problem isn't > those two functions, but the function that is calling them. Is there a way to blacklist a single place where one of these is inlined? I don't think blacklisting the offending function where these are inlined would prevent the crash with 'probe kernel.function("hash_64") {}'. Or would it? After some testing with 3.2.0 and .call, only these two functions have caused crashes so far (in KVM): * inat_get_opcode_attribute * native_set_debugreg The first of these is already included in the blacklist of systemtap git HEAD, but the second one is new. Sami --3XA6nns4nE4KvaS/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCgAGBQJPGBYqAAoJEKLT589SE0a0H14P+QEl8BasHNyWwsuScYb7FnhN 5YM4NyH9WCx6efpkdfqs4CWjej+BuzI+ZcTnunQadsr5cgyXDnhBseL27EgjozMl Aj0339YKRJF/Gqw+e95sc67JlJ9HnNJ6xoukbKEhDzGc2yquRtEaqrDOKiszkQsL jQZCVHMKyDb0eH3HcZpL0pvB9HVzwJfdZ/ASO9zick7wiR47Tmpzn2iVYbdY6HUE H7DS6cVbMl3zSuTsmEtoJnjGQzLp5O31YnKA6G84yfFIgOjEynJp0RLfny2CkEGk x7q1Q1npTkB3AXJntn2avPoHmgHhUH4fn4r4NwkHrjx+j7MNx9L+VTCvGjqiLqUl 9tBJMIXZXXV4oVvUyRTC/zKdtb7EOal4EJtmg+NLuL9TQ4eJ3JOI2Bx3yG3rdOOe 0HHi3EVUnQl5Az1QqqOtoKV4eBWonusXTYY+zaZyyatdjx9mGOPQpjrsA2JHKVHi FxNeYrZ5Ac33kO5YdZdTffZkLjU0DHXhLdZcOxeiVnKWkPldf1WYzOtS8beIr0WA sGO+kqHTBiZMCU9BeLfRYqj5DGLI2TPUIrhwndGZ9f0Yptfzy3P9Ri6lDrlsycKo Oj9Wr/UophwRC6oSJ06AoS2VgkCTGtoSS0+4Jfp81X6rIVbLFOT1Lm7fR1Xs8Hik 2xWrC6uO9KpMoPAoCexr =ZX1y -----END PGP SIGNATURE----- --3XA6nns4nE4KvaS/--