From: "Daniel P. Berrange" <berrange@redhat.com>
To: Josh Stone <jistone@redhat.com>
Cc: systemtap@sourceware.org
Subject: Re: Canonical list of reserved words ?
Date: Thu, 01 Nov 2012 15:53:00 -0000 [thread overview]
Message-ID: <20121101155314.GI7059@redhat.com> (raw)
In-Reply-To: <509299F6.30805@redhat.com>
On Thu, Nov 01, 2012 at 08:49:10AM -0700, Josh Stone wrote:
> On 11/01/2012 07:49 AM, Daniel P. Berrange wrote:
> > We've had fairly frequent bugs in QEMU where generated tapsets contain
> > variables clashing with systemd reserved words. eg
> >
> > https://bugzilla.redhat.com/show_bug.cgi?id=871286
> >
> > Currently QEMU's generator does this
> >
> > for name in e.args.names():
> > # Append underscore to reserved keywords
> > if name in ('limit', 'in', 'next', 'self', 'function'):
> > name += '_'
> > out(' %s = $arg%d;' % (name, i))
> > i += 1
> >
> >
> > To avoid this proper in future I'm looking for a full list of all
> > systemtap reserved words. I've looked at the docs but not found a
> > clear list yet, so can someone point me int he right direction
>
> If it's not in the docs, we should probably add it.
>
> In the source, the list of keywords is populated here:
> http://sourceware.org/git/gitweb.cgi?p=systemtap.git;a=blob;f=parse.cxx#l1329
>
> probe global function if else for foreach in limit return delete
> while break continue next string long try catch
>
> Your list includes "self", which isn't actually significant in stap, but
> that's typical enough that maybe you should just leave it in, and we'll
> feel free to add that one later. :)
Thanks Josh / Frank, I'll update QEMU to match this list.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
prev parent reply other threads:[~2012-11-01 15:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 14:49 Daniel P. Berrange
2012-11-01 15:42 ` Frank Ch. Eigler
2012-11-01 15:49 ` Josh Stone
2012-11-01 15:53 ` Daniel P. Berrange [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121101155314.GI7059@redhat.com \
--to=berrange@redhat.com \
--cc=jistone@redhat.com \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).