Re: print_ubacktrace() and ppc 32

[Lukas Berk <lberk@redhat.com>]

[-- Attachment #1.1: Type: text/plain, Size: 934 bytes --]

Hey,

> > So for a ppc32 kernel we do need a new runtime/unwind/ppc32.h
> > definitions file. It should not be that hard to write based on the
> > ppc64.h version and the ppc32 DWARF register mappings from
> > http://refspecs.linuxbase.org/elf/elfspec_ppc.pdf
> > But note that testing might be needed to see if those really map to
> > actually used DWARF register numbers generated by the toolchain. As can
> > be seen in the comments in ppc64.h sometimes mistakes have been made and
> > theory/spec and practice are not the same :{
> 
> Ok thanks for pointing out. If someone has a first ppc32.h file and needs
> some help for testing on a native 32 bit ppc system, let me know. Or maybe
> in the next week I find the time to implement one.

Looking over the DWARF register specs the mappings should be the same,
so hopefully we can use the same header file.  Would you mind trying
this patch?

Cheers,

Lukas

[-- Attachment #1.2: ppc32.patch --]
[-- Type: text/plain, Size: 417 bytes --]

diff --git a/runtime/unwind/unwind.h b/runtime/unwind/unwind.h
index 056b539..7a4fab8 100644
--- a/runtime/unwind/unwind.h
+++ b/runtime/unwind/unwind.h
@@ -23,7 +23,7 @@ struct unwind_frame_info
 #include "x86_64.h"
 #elif  defined (__i386__)
 #include "i386.h"
-#elif defined (__powerpc64__)
+#elif defined (__powerpc64__) || defined (__powerpc__)
 #include "ppc64.h"
 #elif defined (__s390x__)
 #include "s390x.h"

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]