From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29881 invoked by alias); 9 Dec 2013 10:53:19 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 29807 invoked by uid 89); 9 Dec 2013 10:53:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail9.hitachi.co.jp Received: from Unknown (HELO mail9.hitachi.co.jp) (133.145.228.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Dec 2013 10:53:17 +0000 Received: from mlsv7.hitachi.co.jp (unknown [133.144.234.166]) by mail9.hitachi.co.jp (Postfix) with ESMTP id DBC8F37C84; Mon, 9 Dec 2013 19:53:09 +0900 (JST) Received: from mfilter06.hitachi.co.jp by mlsv7.hitachi.co.jp (8.13.1/8.13.1) id rB9Ar96d006636; Mon, 9 Dec 2013 19:53:09 +0900 Received: from vshuts04.hitachi.co.jp (vshuts04.hitachi.co.jp [10.201.6.86]) by mfilter06.hitachi.co.jp (Switch-3.3.4/Switch-3.3.4) with ESMTP id rB9Ar8w0003323; Mon, 9 Dec 2013 19:53:08 +0900 Received: from gmml27.itg.hitachi.co.jp (unknown [158.213.165.130]) by vshuts04.hitachi.co.jp (Postfix) with ESMTP id E5081140054; Mon, 9 Dec 2013 19:53:07 +0900 (JST) Received: from kbuild-fedora.novalocal by gmml27.itg.hitachi.co.jp (AIX5.2/8.11.6p2/8.11.0) id rB9Ar7o2904288; Mon, 9 Dec 2013 19:53:07 +0900 Subject: [PATCH -tip v5 04/18] [BUGFIX] x86: Prohibit probing on native_set_debugreg To: Ingo Molnar From: Masami Hiramatsu Cc: linux-arch@vger.kernel.org, Jeremy Fitzhardinge , Rusty Russell , Ananth N Mavinakayanahalli , Sandeepa Prabhu , x86@kernel.org, lkml , "Steven Rostedt (Red Hat)" , Chris Wright , Ingo Molnar , Thomas Gleixner , systemtap@sourceware.org, "H. Peter Anvin" , Alok Kataria , "David S. Miller" Date: Mon, 09 Dec 2013 10:53:00 -0000 Message-ID: <20131209104727.13397.43886.stgit@kbuild-fedora.novalocal> In-Reply-To: <20131209104717.13397.8864.stgit@kbuild-fedora.novalocal> References: <20131209104717.13397.8864.stgit@kbuild-fedora.novalocal> User-Agent: StGit/0.16 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-q4/txt/msg00356.txt.bz2 Since the kprobes uses do_debug for single stepping, functions called from do_debug before notify_die must not be probed. This prohibits probing on native_set_debugreg which is used in do_debug. Signed-off-by: Masami Hiramatsu Cc: Jeremy Fitzhardinge Cc: Chris Wright Cc: Alok Kataria Cc: Rusty Russell Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" --- arch/x86/kernel/paravirt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c index 4c785fd..108e685 100644 --- a/arch/x86/kernel/paravirt.c +++ b/arch/x86/kernel/paravirt.c @@ -390,8 +390,9 @@ __visible struct pv_cpu_ops pv_cpu_ops = { .end_context_switch = paravirt_nop, }; -/* At this point, native_get_debugreg has real function entry */ +/* At this point, native_get/set_debugreg has real function entry */ NOKPROBE_SYMBOL(native_get_debugreg); +NOKPROBE_SYMBOL(native_set_debugreg); struct pv_apic_ops pv_apic_ops = { #ifdef CONFIG_X86_LOCAL_APIC