From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106842 invoked by alias); 13 Jul 2016 18:47:28 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 106791 invoked by uid 89); 13 Jul 2016 18:47:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=H*MI:sk:578687B, H*i:sk:578687B, H*f:sk:578687B X-HELO: mail-pa0-f51.google.com Received: from mail-pa0-f51.google.com (HELO mail-pa0-f51.google.com) (209.85.220.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 13 Jul 2016 18:47:21 +0000 Received: by mail-pa0-f51.google.com with SMTP id pp5so13486643pac.3 for ; Wed, 13 Jul 2016 11:47:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jQDvH+4kp88DFHs2cV7PBkL913Q4h7HmZaw1hYySQGI=; b=FkVbE2po+f5aQhQduqpq4fh46wURSB17FI6/X1q2DTAMslO+3iUqBbHAs2968/2WZG tmtERvzrPYiUlemXXtBk985BAnC7zfQedimZ5RIwdCq2Ift2ResOBDTpXfYyNaCX6fC4 eovDLD63jo20JdLNGHJmSGhN3WjA6XPq8v9noAEIbtZvHWD/ooXbABRza09xEsz5joLf uPqDP2MNP4Hlrduh28jclS1JHRWC/QzIFs95mP4r4GJ3sPTKZJVIgE2Rqbj6py6hLlzH AYrAyfXb9Xaf83sgj3v2MKCsB3foveX5sCUoiQ7dwKhF65NKhSz56FDR5zTol8RGo5jZ mnXw== X-Gm-Message-State: ALyK8tIXwuMmetCBV8D5u2lme9Lev7mhTjgmVwKwQxSNJnaqkaxONKiPbnuKgND68vQdQ249 X-Received: by 10.66.182.13 with SMTP id ea13mr16176832pac.89.1468435638300; Wed, 13 Jul 2016 11:47:18 -0700 (PDT) Received: from localhost ([223.188.255.113]) by smtp.gmail.com with ESMTPSA id an13sm6736704pac.42.2016.07.13.11.47.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Jul 2016 11:47:17 -0700 (PDT) Date: Wed, 13 Jul 2016 18:47:00 -0000 From: Pratyush Anand To: David Long Cc: William Cohen , systemtap@sourceware.org, Mark Brown Subject: Re: exercising current aarch64 kprobe support with systemtap Message-ID: <20160713184457.GA27676@localhost.localdomain> References: <599229e0-49ad-1c8e-1055-81e38692e5ec@redhat.com> <575A54D6.2070801@linaro.org> <9ed0b392-ccae-16ff-a473-9b7cec7320b3@redhat.com> <578687B5.5030601@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <578687B5.5030601@linaro.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-IsSubscribed: yes X-SW-Source: 2016-q3/txt/msg00040.txt.bz2 On 13/07/2016:02:25:57 PM, David Long wrote: > On 07/12/2016 10:33 AM, William Cohen wrote: > > On 06/10/2016 01:49 AM, David Long wrote: > > > Attached are incremental diffs I hope will fix the latest systemtap failures, without abandoning atomic sequence checking. I'm trying to avoid the hex constants but I don't think the insn.c functions help in this case. > > > > > > -dl > > > > > > > Hi Dave, > > > > Is this heuristic to limit the search to not go past the prologue going to be included in the arm64 kprobe patches? I ran the current v15 patches and saw that some of the tests were failing becuase some of the problems were unseccussful in registering as seen below in the output of systemtap.log. -Will > > > > spawn stap /root/systemtap_write/systemtap/testsuite/systemtap.base/bz1027459.stp > > > > WARNING: probe kernel.function("SyS_set_tid_address@kernel/fork.c:1236").call (address 0xfffffc00080c5f00) registration error (rc -22) > > > > WARNING: probe kernel.function("SyS_sched_setaffinity@kernel/sched/core.c:4706").call (address 0xfffffc00081010e8) registration error (rc -22) > > > > WARNING: probe kernel.function("SyS_sched_get_priority_min@kernel/sched/core.c:5029").call (address 0xfffffc00081015e8) registration error (rc -22) > > > > WARNING: probe kernel.function("SyS_sched_get_priority_max@kernel/sched/core.c:5002").call (address 0xfffffc0008101580) registration error (rc -22) > > > > hi > > > > FAIL: bz1027459 -p5 (0) > > > > spawn stap -v /root/systemtap_write/systemtap/testsuite/systemtap.base/equal.stp > > > > Pass 1: parsed user script and 115 library scripts using 51968virt/38784res/6976shr/32576data kb, in 190usr/0sys/202real ms. > > > > Pass 2: analyzed script: 4 probes, 1 function, 0 embeds, 2 globals using 91776virt/82176res/7744shr/72384data kb, in 1230usr/10sys/1241real ms. > > > > Pass 3: translated to C into "/tmp/stapK5F1ze/stap_5a080310fa71fdec33340dcee0389f80_1969_src.c" using 91776virt/82432res/8000shr/72384data kb, in 0usr/0sys/11real ms. > > > > Pass 4: compiled C into "stap_5a080310fa71fdec33340dcee0389f80_1969.ko" in 3190usr/640sys/3803real ms. > > > > Pass 5: starting run. > > > > WARNING: probe kernel.function("schedule@kernel/sched/core.c:3369") (address 0xfffffc00088f65c0) registration error (rc -22) > > > > systemtap starting probe > > > > FAIL: systemtap.base/equal.stp startup (timeout) > > > > spawn stap -v /root/systemtap_write/systemtap/testsuite/systemtap.base/finloop2.stp > > > > Pass 1: parsed user script and 115 library scripts using 52032virt/38848res/6976shr/32640data kb, in 200usr/0sys/204real ms. > > > > Pass 2: analyzed script: 4 probes, 1 function, 0 embeds, 2 globals using 91840virt/82240res/7744shr/72448data kb, in 1230usr/10sys/1246real ms. > > > > Pass 3: translated to C into "/tmp/stapfwr7Sg/stap_177624071ced2b52cbbfd6b4ea09dd28_1964_src.c" using 91840virt/82496res/8000shr/72448data kb, in 10usr/10sys/11real ms. > > > > Pass 4: compiled C into "stap_177624071ced2b52cbbfd6b4ea09dd28_1964.ko" in 3230usr/620sys/3812real ms. > > > > Pass 5: starting run. > > > > WARNING: probe kernel.function("schedule@kernel/sched/core.c:3369") (address 0xfffffc00088f65c0) registration error (rc -22) > > > > systemtap starting probe > > > > FAIL: systemtap.base/finloop2.stp startup (timeout) > > > > spawn stap -v /root/systemtap_write/systemtap/testsuite/systemtap.base/kfunct.stp > > > > Pass 1: parsed user script and 115 library scripts using 52032virt/38848res/6976shr/32640data kb, in 190usr/10sys/201real ms. > > > > Pass 2: analyzed script: 4 probes, 1 function, 0 embeds, 1 global using 91840virt/82240res/7744shr/72448data kb, in 1240usr/10sys/1245real ms. > > > > Pass 3: translated to C into "/tmp/stap8zsRzS/stap_2fa61ae7aa177442cb013709494408e9_1680_src.c" using 91840virt/82496res/8000shr/72448data kb, in 10usr/0sys/11real ms. > > > > Pass 4: compiled C into "stap_2fa61ae7aa177442cb013709494408e9_1680.ko" in 3210usr/620sys/3789real ms. > > > > Pass 5: starting run. > > > > WARNING: probe kernel.function("schedule@kernel/sched/core.c:3369") (address 0xfffffc00088f65c0) registration error (rc -22) > > > > systemtap starting probe > > > > FAIL: systemtap.base/kfunct.stp startup (timeout) > > > > > > I don't think we ever closed the loop on whether this was a good idea or I think, we should go with that improvement of recognising "stp x29,x30,[sp,...]" until we have something from compiler to recognize .word instructions. > not. This code is not present in v15. So, please take that in next revision. ~Pratyush