From: "Frank Ch. Eigler" <fche@redhat.com>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: systemtap@sourceware.org
Subject: Re: issues about the systemtap log file name
Date: Fri, 01 Jun 2018 19:27:00 -0000 [thread overview]
Message-ID: <20180601192741.GB31664@redhat.com> (raw)
In-Reply-To: <CALOAHbACLyuma3NddKthVY7=CE2R1S-3Ag=83qkk8xjzuVabKQ@mail.gmail.com>
Hi -
> currently we can use '-s' option to specify the maximum size of output
> file and the maximum number of output files i.e.,
>
> > stap -F -o test.output -S 128,10 test.stp
>
> The issue here is the output file names will be from test.output.0 to
> test.output.INT_MAX, that is not friendly if we continuesly run
> systemtap.
>
> So I give a suggestion that, if the 'N' of '-S size[,N]' is set, the
> output file name should be from
> output_filename.0 to output_filename.(N-1) and then rotate begin with
> output_filename.0.
That makes perfect sense.
> The attachment is my patch to fix this issue. hope it could help.
> I can't find how to submit a patch to your open source git tree, so I
> just email to you.
(The README file points to HACKING, which points to several ways.)
In this rotatingly-named file case, is there any need to remove
old files? Can we just drop that part, and let stap incidentally
truncate the output-$N files is it goes? If so, the code could
be simplified even more.
- FChE
next parent reply other threads:[~2018-06-01 19:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CALOAHbACLyuma3NddKthVY7=CE2R1S-3Ag=83qkk8xjzuVabKQ@mail.gmail.com>
2018-06-01 19:27 ` Frank Ch. Eigler [this message]
2018-06-02 13:36 ` Yafang Shao
2018-06-02 15:17 ` Yafang Shao
2018-06-12 2:49 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180601192741.GB31664@redhat.com \
--to=fche@redhat.com \
--cc=laoar.shao@gmail.com \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).