From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68839 invoked by alias); 7 Nov 2019 18:52:07 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 68821 invoked by uid 89); 7 Nov 2019 18:52:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=heavy, lying, interest X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-1.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (205.139.110.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Nov 2019 18:52:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573152723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CNCuSctJpHfkxjVFPkx1FaoMcQKC9NJYLs2QyDeReiY=; b=RytTPrjYtgInrOrTh2XB0GPdXRtBkUsxYLSvH/3QhkT04z4E8ErcEvfYGsmO2/mroPzLcp O2yolspN5aAyrUq5H/czCj5fMcuHQO7Tik+tuo3iWD9fOXZ1efAAOL+bdSB33UDhB8TGr4 5+eyW2EoaUKcYMQcd4TNQokrEAAL6Pg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-28-nfMEE-YGOTqyrs6Z2HyG5Q-1; Thu, 07 Nov 2019 13:51:59 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A9E8D107ACC3; Thu, 7 Nov 2019 18:51:58 +0000 (UTC) Received: from redhat.com (ovpn-116-53.phx2.redhat.com [10.3.116.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8C0A41001DC0; Thu, 7 Nov 2019 18:51:58 +0000 (UTC) Received: from fche by redhat.com with local (Exim 4.92) (envelope-from ) id 1iSmsv-0005jA-6X; Thu, 07 Nov 2019 13:51:57 -0500 Date: Thu, 07 Nov 2019 18:52:00 -0000 From: "Frank Ch. Eigler" To: Craig Ringer Cc: systemtap@sourceware.org Subject: Re: Newbie Notes Message-ID: <20191107185157.GA19461@redhat.com> References: <87bltyf0zp.fsf@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-SW-Source: 2019-q4/txt/msg00031.txt.bz2 Hi - > OK. Take this script, which will work on anything you have lying around > with simple adaptations: > [...] Ah. Yes, the unused-variable warnings are suppressed, but only for script located in a tapset. If you put that first alias definition into a separate directory/file, and run with stap -I$dir, then you will not see those warnings. > The issue is specifically within @var and @cast expansion. It's done earl= y, > and doesn't appear to benefit from implicit string concatenation at all, > macro-expanded or otherwise. Per my other post. [...] > but not this (where $1 =3D /usr/pgsql-11/ ): >=20 > @define PGBIN %( @1 "bin/postgres" %) > function get_pgver:long() { > return @var("server_version_num@guc.c", @PGBIN); > } > probe process(@PGBIN).function("PostgresMain") { > printf("%s", @PGBIN, get_pgver()); > } OK, working on this bug. > [...] I'm talking about how --monitor decides what is / isn't a > hit. Does using "next" in a probe alias body suppress it? etc. It should count every distinct probe whose handler starts executing, so definitely include those that run through to a 'next'. > As a heavy user of perf's "perf top", stap's --monitor is of great intere= st > to me. By the way, see also stap --example eventcount.stp=20 > [...] - FChE