From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74883 invoked by alias); 7 Feb 2020 09:51:36 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 74874 invoked by uid 89); 7 Feb 2020 09:51:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.1 spammy=21AM, 21am, sk:dhatay, U*d.hatayama X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Feb 2020 09:51:35 +0000 Received: from librem (unknown [145.15.244.24]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id A59483000850; Fri, 7 Feb 2020 10:51:31 +0100 (CET) Received: by librem (Postfix, from userid 1000) id 83162C3EE5; Fri, 7 Feb 2020 10:51:15 +0100 (CET) Date: Fri, 07 Feb 2020 09:51:00 -0000 From: Mark Wielaard To: "d.hatayama@fujitsu.com" Cc: "'systemtap@sourceware.org'" Subject: Re: [PATCH] loc2c-runtime: fix compilation failure Message-ID: <20200207095115.GM42691@wildebeest.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-IsSubscribed: yes X-SW-Source: 2020-q1/txt/msg00012.txt Hi, On Fri, Feb 07, 2020 at 04:07:21AM +0000, d.hatayama@fujitsu.com wrote: > I ran into the following compilation failure when I tried to change > $return in a return probe for some user-space process: > [...] > This failure is caused by a typo of the name of an argument variable > of macro u_store_register introduced at the commit > a03b455bc656216a4829dbad08e630949d944c75. > --- > runtime/linux/loc2c-runtime.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/runtime/linux/loc2c-runtime.h b/runtime/linux/loc2c-runtime.h > index b4a329b..0270fa1 100644 > --- a/runtime/linux/loc2c-runtime.h > +++ b/runtime/linux/loc2c-runtime.h > @@ -294,7 +294,7 @@ static void ursl_store64 (const struct usr_regset_lut* lut,unsigned lutsize, in > #define uu_store_register(_regs,regno,value) (_stp_is_compat_task() ? ursl_store32(url_i386, ARRAY_SIZE(url_i386), EM_386, regno, value) : ursl_store64(url_x86_64, ARRAY_SIZE(url_x86_64), EM_X86_64, regno, value)) > > #define u_fetch_register(regno) check_fetch_register(c->uregs,regno,_stp_is_compat_task()?ARRAY_SIZE(url_i386):ARRAY_SIZE(url_x86_64),uu_fetch_register) > -#define u_store_register(regno,value) check_store_register(c->uregs,regnoo,_stp_is_compat_task()?ARRAY_SIZE(url_i386):ARRAY_SIZE(url_x86_64),value,uu_store_register) > +#define u_store_register(regno,value) check_store_register(c->uregs,regno,_stp_is_compat_task()?ARRAY_SIZE(url_i386):ARRAY_SIZE(url_x86_64),value,uu_store_register) > > #endif This looks completely correct. The typo is pretty clear in the original commit. I am just surprised we haven't seen this issue before since the commit was pushed almost a year ago. What was the exact script that showed this issue? We should probably add it as a testcase together with the fix. Thanks, Mark