From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 647983844026 for ; Mon, 30 Nov 2020 19:58:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 647983844026 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-288-6YAHGeIVP6aVk0MpHDb5Ag-1; Mon, 30 Nov 2020 14:58:45 -0500 X-MC-Unique: 6YAHGeIVP6aVk0MpHDb5Ag-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3193A1842156 for ; Mon, 30 Nov 2020 19:58:44 +0000 (UTC) Received: from localhost.localdomain (ovpn-114-226.phx2.redhat.com [10.3.114.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id DC5EC5D6AB; Mon, 30 Nov 2020 19:58:43 +0000 (UTC) From: Tom Stellard To: systemtap@sourceware.org Cc: =?UTF-8?q?Timm=20B=C3=A4der?= Subject: [PATCH 1/8] Fix a few class/struct mixups Date: Mon, 30 Nov 2020 19:58:34 +0000 Message-Id: <20201130195841.26142-2-tstellar@redhat.com> In-Reply-To: <20201130195841.26142-1-tstellar@redhat.com> References: <20201130195841.26142-1-tstellar@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: systemtap@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Systemtap mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2020 19:58:48 -0000 From: Timm Bäder This breaks the build with clang, e.g.: ./elaborate.h:47:1: error: 'symresolution_info' defined as a struct here but previously declared as a class; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags] --- dwflpp.h | 2 +- loc2stap.h | 2 +- session.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dwflpp.h b/dwflpp.h index 25e583908..46813805f 100644 --- a/dwflpp.h +++ b/dwflpp.h @@ -182,7 +182,7 @@ struct inline_instance_info : base_func_info }; struct location; -struct location_context; +class location_context; struct dwflpp { diff --git a/loc2stap.h b/loc2stap.h index 818314bb2..df60571a2 100644 --- a/loc2stap.h +++ b/loc2stap.h @@ -41,7 +41,7 @@ struct location { } }; -class dwflpp; +struct dwflpp; class location_context { public: diff --git a/session.h b/session.h index 38f1d66de..f60da3e1e 100644 --- a/session.h +++ b/session.h @@ -123,7 +123,7 @@ struct parse_error: public std::runtime_error }; -class symresolution_info; +struct symresolution_info; struct systemtap_session { -- 2.26.2