From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id B52DF393BC07 for ; Mon, 30 Nov 2020 19:58:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B52DF393BC07 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-296-NtzmHuaONjePr3fRdSyOEA-1; Mon, 30 Nov 2020 14:58:45 -0500 X-MC-Unique: NtzmHuaONjePr3fRdSyOEA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 95383184215C for ; Mon, 30 Nov 2020 19:58:44 +0000 (UTC) Received: from localhost.localdomain (ovpn-114-226.phx2.redhat.com [10.3.114.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4D9695D705; Mon, 30 Nov 2020 19:58:44 +0000 (UTC) From: Tom Stellard To: systemtap@sourceware.org Cc: =?UTF-8?q?Timm=20B=C3=A4der?= Subject: [PATCH 2/8] util: Use abs() instead of labs() Date: Mon, 30 Nov 2020 19:58:35 +0000 Message-Id: <20201130195841.26142-3-tstellar@redhat.com> In-Reply-To: <20201130195841.26142-1-tstellar@redhat.com> References: <20201130195841.26142-1-tstellar@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-14.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: systemtap@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Systemtap mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2020 19:58:48 -0000 From: Timm Bäder Taking the absolute value of unsigned values is pointless, as reported by clang: util.cxx:1545:28: error: taking the absolute value of unsigned type 'unsigned long' has no effect [-Werror,-Wabsolute-value] unsigned min_score = labs(target.size() - it->size()); ^ util.cxx:1545:28: note: remove the call to 'labs' since unsigned values cannot be negative unsigned min_score = labs(target.size() - it->size()); --- util.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util.cxx b/util.cxx index c31b668a3..bcacacaaf 100644 --- a/util.cxx +++ b/util.cxx @@ -1542,7 +1542,7 @@ levenshtein_suggest(const string& target, // string to match against // Approximate levenshtein by size-difference only; real score // is at least this high - unsigned min_score = labs(target.size() - it->size()); + unsigned min_score = abs(static_cast(target.size()) - static_cast(it->size())); if (min_score > threshold) // min-score too high for threshold continue; -- 2.26.2