From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 1DA5A3844026 for ; Mon, 30 Nov 2020 19:58:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1DA5A3844026 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-403-C11g_-3KObqw8hZ_JANhZw-1; Mon, 30 Nov 2020 14:58:46 -0500 X-MC-Unique: C11g_-3KObqw8hZ_JANhZw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 68B0C3E748 for ; Mon, 30 Nov 2020 19:58:45 +0000 (UTC) Received: from localhost.localdomain (ovpn-114-226.phx2.redhat.com [10.3.114.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1F6685D6A8; Mon, 30 Nov 2020 19:58:45 +0000 (UTC) From: Tom Stellard To: systemtap@sourceware.org Cc: =?UTF-8?q?Timm=20B=C3=A4der?= Subject: [PATCH 4/8] Add missing copy constructors to set1_ref and set1_const_ref Date: Mon, 30 Nov 2020 19:58:37 +0000 Message-Id: <20201130195841.26142-5-tstellar@redhat.com> In-Reply-To: <20201130195841.26142-1-tstellar@redhat.com> References: <20201130195841.26142-1-tstellar@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-15.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: systemtap@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Systemtap mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Nov 2020 19:58:50 -0000 From: Timm Bäder Clang complains about the missing copy constructors if a user-defined copy assignment operator exists, e.g.: ./bpf-bitset.h:108:19: error: definition of implicit copy constructor for 'set1_const_ref' is deprecated because it has a user-declared copy assignment operator [-Werror,-Wdeprecated-copy] set1_const_ref& operator= (const set1_const_ref &); // not present ^ ./bpf-bitset.h:256:12: note: in implicit copy constructor for 'bpf::bitset::set1_const_ref' first required here return set1_const_ref(data + w2 * i, w2); ^ --- bpf-bitset.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/bpf-bitset.h b/bpf-bitset.h index db4eb0846..6c2f74f0f 100644 --- a/bpf-bitset.h +++ b/bpf-bitset.h @@ -115,6 +115,7 @@ public: static const size_t npos = -1; set1_const_ref(word_t *d, size_t w) : data(d), words(w) { } + set1_const_ref(const set1_const_ref &o) : data(o.data), words(o.words) { } bool operator!= (const set1_const_ref &o) const { @@ -149,6 +150,7 @@ private: public: set1_ref(size_t *d, size_t w) : set1_const_ref(d, w) { } + set1_ref(const set1_ref &o) : set1_const_ref(o.data, o.words) { } bit_ref operator[] (size_t i) { -- 2.26.2