From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id A1C593858D29 for ; Thu, 23 Sep 2021 23:00:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A1C593858D29 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-391-CRzKaDuONTCkuF_oWng6-g-1; Thu, 23 Sep 2021 19:00:37 -0400 X-MC-Unique: CRzKaDuONTCkuF_oWng6-g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2FECB1006AA4 for ; Thu, 23 Sep 2021 23:00:36 +0000 (UTC) Received: from redhat.com (ovpn-112-154.phx2.redhat.com [10.3.112.154]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D000C60C05; Thu, 23 Sep 2021 23:00:14 +0000 (UTC) Received: from fche by redhat.com with local (Exim 4.94.2) (envelope-from ) id 1mTXhL-0005qP-SI; Thu, 23 Sep 2021 19:00:12 -0400 Date: Thu, 23 Sep 2021 19:00:11 -0400 From: "Frank Ch. Eigler" To: Nir Soffer Cc: systemtap@sourceware.org, David Teigland Subject: Re: [PATCH] Fix traceaio with IO_CMD_{PREAD,PWRITE} Message-ID: <20210923230011.GC15826@redhat.com> References: <20210923174903.605613-1-nsoffer@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: systemtap@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Systemtap mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Sep 2021 23:00:40 -0000 Hi - > This works: > > global IO_CMD_PREADV = 7 > global IO_CMD_PWRITEV = 8 > > Do we have a better way to handle this? Within a tapset snippet, code can use @const("IO_CMD_PREADV") referring to an identifier in embedded-C scope. If the IO_CMD_PREADV identifier were an enum value that shows up in DWARF, then $IO_CMD_PREADV can resolve in recent versions of stap. If none of the above, yeah, use the global gadget. - FChE