From: Nir Soffer <nsoffer@redhat.com>
To: systemtap@sourceware.org
Cc: fche@redhat.com, Nir Soffer <nsoffer@redhat.com>
Subject: [PATCH] Fix iovec logging for PWRITEV
Date: Wed, 29 Sep 2021 12:51:05 +0300 [thread overview]
Message-ID: <20210929095105.1088353-1-nsoffer@redhat.com> (raw)
In commit 9c1f3884e43c7939c069995774e4db1163def429
Fix traceaio with IO_CMD_{PREAD,PWRITE}
IOCB_CMD_PREADV was used twice, skipping logging of iovecs for
IOCB_CMD_PWRITEV.
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
---
testsuite/systemtap.examples/io/traceaio.stp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testsuite/systemtap.examples/io/traceaio.stp b/testsuite/systemtap.examples/io/traceaio.stp
index b1d220773..7904646a6 100755
--- a/testsuite/systemtap.examples/io/traceaio.stp
+++ b/testsuite/systemtap.examples/io/traceaio.stp
@@ -30,7 +30,7 @@ probe syscall.io_submit
printf(" iocb[%4d]=%p, fd=%d, opcode=%d, offset=%d, nbytes=%d, buf=%p\n",
i, iocbp, fd, opcode, offset, nbytes, buf)
- if (opcode == @IOCB_CMD_PREADV || opcode == @IOCB_CMD_PREADV) {
+ if (opcode == @IOCB_CMD_PREADV || opcode == @IOCB_CMD_PWRITEV) {
for (j = 0; j < nbytes; j++) {
iovecp = &@cast(buf, "iovec", "kernel<linux/uio.h>")[j]
base = user_uint64(&@cast(iovecp, "iovec", "kernel<linux/uio.h>")->iov_base)
--
2.31.1
reply other threads:[~2021-09-29 9:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210929095105.1088353-1-nsoffer@redhat.com \
--to=nsoffer@redhat.com \
--cc=fche@redhat.com \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).