From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 3E1373858D28 for ; Wed, 29 Sep 2021 09:51:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3E1373858D28 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-467-YqDv1-PzOpOguwEeOFVGwQ-1; Wed, 29 Sep 2021 05:51:08 -0400 X-MC-Unique: YqDv1-PzOpOguwEeOFVGwQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A1E4A10144E1 for ; Wed, 29 Sep 2021 09:51:07 +0000 (UTC) Received: from sparse.redhat.com (unknown [10.35.207.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9117F100164A; Wed, 29 Sep 2021 09:51:06 +0000 (UTC) From: Nir Soffer To: systemtap@sourceware.org Cc: fche@redhat.com, Nir Soffer Subject: [PATCH] Fix iovec logging for PWRITEV Date: Wed, 29 Sep 2021 12:51:05 +0300 Message-Id: <20210929095105.1088353-1-nsoffer@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" X-Spam-Status: No, score=-14.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: systemtap@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Systemtap mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Sep 2021 09:51:11 -0000 In commit 9c1f3884e43c7939c069995774e4db1163def429 Fix traceaio with IO_CMD_{PREAD,PWRITE} IOCB_CMD_PREADV was used twice, skipping logging of iovecs for IOCB_CMD_PWRITEV. Signed-off-by: Nir Soffer --- testsuite/systemtap.examples/io/traceaio.stp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testsuite/systemtap.examples/io/traceaio.stp b/testsuite/systemtap.examples/io/traceaio.stp index b1d220773..7904646a6 100755 --- a/testsuite/systemtap.examples/io/traceaio.stp +++ b/testsuite/systemtap.examples/io/traceaio.stp @@ -30,7 +30,7 @@ probe syscall.io_submit printf(" iocb[%4d]=%p, fd=%d, opcode=%d, offset=%d, nbytes=%d, buf=%p\n", i, iocbp, fd, opcode, offset, nbytes, buf) - if (opcode == @IOCB_CMD_PREADV || opcode == @IOCB_CMD_PREADV) { + if (opcode == @IOCB_CMD_PREADV || opcode == @IOCB_CMD_PWRITEV) { for (j = 0; j < nbytes; j++) { iovecp = &@cast(buf, "iovec", "kernel")[j] base = user_uint64(&@cast(iovecp, "iovec", "kernel")->iov_base) -- 2.31.1