From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by sourceware.org (Postfix) with ESMTPS id 5E9233858022 for ; Fri, 3 Dec 2021 10:15:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5E9233858022 From: Alexander Kanavin To: smakarov@redhat.com, systemtap@sourceware.org Cc: Alexander Kanavin Subject: [PATCH] staprun: address ncurses 6.3 failures Date: Fri, 3 Dec 2021 11:15:20 +0100 Message-Id: <20211203101520.1097991-1-alex@linutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: systemtap@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Systemtap mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Dec 2021 10:15:29 -0000 These happen otherwise: | ../../git/staprun/monitor.c: In function 'monitor_render': | ../../git/staprun/monitor.c:450:27: error: field width specifier '*' expects argument of type 'int', but argument 3 has type 'size_t' {aka 'long unsigned int'} [-Werror=format=] | 450 | wprintw(status, "\n%*s\t%*s\t%*s\t%*s\t%*s\t%*s\t%s\n", | | ~^~ | | | | | int | 451 | width[p_index], HIGHLIGHT("index", p_index, comp_fn_index), | | ~~~~~~~~~~~~~~ | | | | | size_t {aka long unsigned int} --- staprun/monitor.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/staprun/monitor.c b/staprun/monitor.c index 478634c09..f4fbfd686 100644 --- a/staprun/monitor.c +++ b/staprun/monitor.c @@ -448,12 +448,12 @@ void monitor_render(void) if (active_window == 0) wattron(status, A_BOLD); wprintw(status, "\n%*s\t%*s\t%*s\t%*s\t%*s\t%*s\t%s\n", - width[p_index], HIGHLIGHT("index", p_index, comp_fn_index), - width[p_state], HIGHLIGHT("state", p_state, comp_fn_index), - width[p_hits], HIGHLIGHT("hits", p_hits, comp_fn_index), - width[p_min], HIGHLIGHT("min", p_min, comp_fn_index), - width[p_avg], HIGHLIGHT("avg", p_avg, comp_fn_index), - width[p_max], HIGHLIGHT("max", p_max, comp_fn_index), + (int)width[p_index], HIGHLIGHT("index", p_index, comp_fn_index), + (int)width[p_state], HIGHLIGHT("state", p_state, comp_fn_index), + (int)width[p_hits], HIGHLIGHT("hits", p_hits, comp_fn_index), + (int)width[p_min], HIGHLIGHT("min", p_min, comp_fn_index), + (int)width[p_avg], HIGHLIGHT("avg", p_avg, comp_fn_index), + (int)width[p_max], HIGHLIGHT("max", p_max, comp_fn_index), HIGHLIGHT("name", p_name, comp_fn_index)); if (active_window == 0) wattroff(status, A_BOLD); @@ -466,17 +466,17 @@ void monitor_render(void) json_object *probe, *field; probe = json_object_array_get_idx(jso_probe_list, i); json_object_object_get_ex(probe, "index", &field); - wprintw(status, "%*s\t", width[p_index], json_object_get_string(field)); + wprintw(status, "%*s\t", (int)width[p_index], json_object_get_string(field)); json_object_object_get_ex(probe, "state", &field); - wprintw(status, "%*s\t", width[p_state], json_object_get_string(field)); + wprintw(status, "%*s\t", (int)width[p_state], json_object_get_string(field)); json_object_object_get_ex(probe, "hits", &field); - wprintw(status, "%*s\t", width[p_hits], json_object_get_string(field)); + wprintw(status, "%*s\t", (int)width[p_hits], json_object_get_string(field)); json_object_object_get_ex(probe, "min", &field); - wprintw(status, "%*s\t", width[p_min], json_object_get_string(field)); + wprintw(status, "%*s\t", (int)width[p_min], json_object_get_string(field)); json_object_object_get_ex(probe, "avg", &field); - wprintw(status, "%*s\t", width[p_avg], json_object_get_string(field)); + wprintw(status, "%*s\t", (int)width[p_avg], json_object_get_string(field)); json_object_object_get_ex(probe, "max", &field); - wprintw(status, "%*s\t", width[p_max], json_object_get_string(field)); + wprintw(status, "%*s\t", (int)width[p_max], json_object_get_string(field)); getyx(status, discard, cur_x); json_object_object_get_ex(probe, "name", &field); wprintw(status, "%.*s", max_cols-cur_x-1, json_object_get_string(field)); -- 2.20.1