From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id 18FB93858424 for ; Mon, 18 Dec 2023 05:02:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 18FB93858424 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 18FB93858424 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::531 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702875723; cv=none; b=RxSK4u5S0JyeazFz9cQEHhw+u3DZN88s4V0/XBX0pgaRy6c1wG0OEUZWxtqeH2Q945QFKZC86jCD6w7K7zxPZl9GnRfrDXJW2xA1KAbo8r22qSunNc/qECNLEHUXygC0jSl7qc4KscYee5SaNiEsXIGrmrDLGzEvd0IVJ8+XBos= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702875723; c=relaxed/simple; bh=ltySGzQk1vvtsL7q3AMMEMfver9u+Tuvd6O7fuPLGGU=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=KK6/ULH+mRrcvRK1tX1knTqI87Ujv7eSLkwTZ/mIsk07tA17l0vnPUv3mcpCW7aquT2bAArkI0IylrjrE8jUTvIu27odD9jMjaJ3dpEZLMLo85Z//7jzA1thJYEacO4imTG/AbrkrudBJpc1OS5zJ1T4c7SpyauM/TQ2CeaIVQc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-5c673b01eeeso805460a12.1 for ; Sun, 17 Dec 2023 21:02:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702875720; x=1703480520; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GRx32o+U6QwBWqquuzfe5rln4CJF1ZNzgsbZjuhigxg=; b=k/XjpVRSU3XTf/zQ/Hni5z0vuiiW1VfiVrSHtAfwgxFYntdip+TyyIeZrHuDj3WLPj fkX/cet+tO30Usb+xDgFnG3qP0FeSxmWHEFzgCcZoR+k5cL7mUVxn6bnmeU0xH75L2MH Y+k+g1hQXYkO69vMC91MoAmm86XiJOEGn0ZLZBKomPpyx4AvxEAsa3yIL3oc6A5rZa78 M0wglOQ4mDua8adf1GL4yjC2xNl3V6R12yC9ddb41S5/ez2iWTY485Nf2MIRPfGCggWz vUsXAkz696ffRPaQ16oXoDmnzaVeKPvQ2mhDDMi817lHslBf4x2VY1IY3qTgGC5XZ7ht LEdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702875720; x=1703480520; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GRx32o+U6QwBWqquuzfe5rln4CJF1ZNzgsbZjuhigxg=; b=oSej+KzMpm4ZtdwfKqniKYwgUlV8z2kDTrSja80MW+P+2v0xYq+0YKyNZzxzXfSmrW XULeoUY6O6dWoozJTAtEWfX2juOq/3vyqSCXa7iHc4rKG0cWB+mOlXXv1lg3bImrnRel cGwsdeS4SRzAPb/02fMccXi+xnA/BhzcBrUF847Y9PS6KtUalvTMCMflE2qXmaQ5nnb7 PHahbVO+bNVS5TGPYsE0z3EGKX9j4gMESYIV7wJ0tLSmaVNuPXyrDISJk+qkcP502o5w eDarxCDPXQ019EEoCgQkYuAra+bq/1e/6wJ0+n2E7kank5zI/bbd79/doMXFPaPAlZQa dsTg== X-Gm-Message-State: AOJu0Yz2c5kdoDXIzhAsY9mjDqN/RPUbB8xsJyya3wtMgyxDxocXzl2p SnzByCJbYWYmsyVEUvTce4mULbdDoJI= X-Google-Smtp-Source: AGHT+IGRkDWgnfB9PWvyvhc0YZP9cP+vqG5nTbb5XMGbhVVXCaFpG8D5gnCnymfuxBbVHqp434RxXA== X-Received: by 2002:a17:902:728e:b0:1d0:6ffd:f21c with SMTP id d14-20020a170902728e00b001d06ffdf21cmr7180357pll.114.1702875720344; Sun, 17 Dec 2023 21:02:00 -0800 (PST) Received: from kamensky-p15s.cisco.com ([2601:641:8080:1a70::73a5]) by smtp.gmail.com with ESMTPSA id k9-20020a170902c40900b001bc676df6a9sm17990406plk.132.2023.12.17.21.01.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 Dec 2023 21:02:00 -0800 (PST) From: Victor Kamensky To: systemtap@sourceware.org Cc: "Frank Ch . Eigler" , Victor Kamensky Subject: [PATCH 1/2] configure.ac: fix broken libdebuginfod library auto detection Date: Sun, 17 Dec 2023 21:01:34 -0800 Message-Id: <20231218050135.12565-1-victor.kamensky7@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: After 2e67b053e3796ee7cf29a39f9698729b52078406 "configury: rework debuginfod searches" commit, libdebuginfod.so library auto detection is broken. It was reported by Martin Jansa on openembedded-core mailing list [1]. Currently configure.ac does "AC_DEFINE([HAVE_LIBDEBUGINFOD], [1] ..." as long as no --without-debuginfod option is passed, regardless PKG_CHECK_MODULES check result. It seems to be bad copy/paste. Address the issue by moving the AC_DEFINE back to PKG_CHECK_MODULES action-if-found block. To reproduce the issue on FC system, one can do the following "sudo dnf remove elfutils-debuginfod-client-devel" and then try to build SystemTap util.cxx will fail to compile because of missing elfutils/debuginfod.h because config.h will have "#define HAVE_LIBDEBUGINFOD 1", while config.log and configure output indicates that check for libdebuginfod library failed. [1] https://lists.openembedded.org/g/openembedded-core/message/192109?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Acreated%2C0%2Csystemtap%2C20%2C2%2C0%2C102987514 Signed-off-by: Victor Kamensky --- configure.ac | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index d9559c5c3..18cd7f84a 100644 --- a/configure.ac +++ b/configure.ac @@ -219,12 +219,11 @@ dnl take the user at his or her word elif test "x$with_debuginfod" != xno; then dnl check in the system pkgconfig PKG_CHECK_MODULES([debuginfod], [libdebuginfod >= 0.179], - [have_debuginfod=1], + [have_debuginfod=1 + AC_DEFINE([HAVE_LIBDEBUGINFOD], [1], [Define to 1 if debuginfod is enabled.])], [if test "x$with_debuginfod" = xyes; then AC_MSG_ERROR(["--with-debuginfod was given, but libdebuginfod is missing or unusable."]) fi]) - AC_DEFINE([HAVE_LIBDEBUGINFOD], [1], [Define to 1 if debuginfod is enabled.]) - AC_MSG_RESULT([yes]) else AC_MSG_RESULT([no]) fi -- 2.31.1