From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-24843-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 106912 invoked by alias); 26 Aug 2016 21:21:04 -0000
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <systemtap.sourceware.org>
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
Received: (qmail 106903 invoked by uid 89); 26 Aug 2016 21:21:03 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*i:sk:41e77cd, H*MI:sk:41e77cd, H*f:sk:41e77cd
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 Aug 2016 21:21:02 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id D6BB6C0AA39E	for <systemtap@sourceware.org>; Fri, 26 Aug 2016 21:21:01 +0000 (UTC)
Received: from [10.3.116.204] (ovpn-116-204.phx2.redhat.com [10.3.116.204])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7QLL1bE025264;	Fri, 26 Aug 2016 17:21:01 -0400
Subject: Re: Some newbie questions
To: systemtap@sourceware.org, David Smith <dsmith@redhat.com>
References: <91592a2a-7373-6a27-413c-cf4aca70cb76@scylladb.com> <y0m60r8k5as.fsf@fche.csb> <bc6d9531-cfa4-da2f-3d05-45eaadaedbd6@scylladb.com> <20160810164742.GF13748@redhat.com> <382185d7-86d6-45d0-1855-d7e3c1639083@scylladb.com> <42a5bad6-c094-cb7a-6f89-a592367ca30b@scylladb.com> <20160811161845.GC12190@redhat.com> <e8a55f7f-8ba3-99ba-8ff3-64fabffd6f12@scylladb.com> <y0minuze060.fsf@fche.csb> <8af2d587-ebc0-730b-3b1c-a452c486af57@scylladb.com> <20160817183537.GB4647@redhat.com> <c8c0f0b6-f8a7-7104-9faf-a30e89076e5f@scylladb.com> <7a45c7b4-59b9-e0f8-77a5-d7ce3634fcfc@redhat.com> <0d91a649-873b-6d89-a5ef-ae88d11ce588@scylladb.com> <41e77cd5-5ecb-1076-d005-4a7fd454a450@redhat.com>
From: Josh Stone <jistone@redhat.com>
Message-ID: <22093f91-bcd6-d71f-5d58-506becf6c8e1@redhat.com>
Date: Fri, 26 Aug 2016 21:21:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <41e77cd5-5ecb-1076-d005-4a7fd454a450@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2016-q3/txt/msg00212.txt.bz2

On 08/26/2016 01:07 PM, David Smith wrote:
> --- a/tapset-utrace.cxx
> +++ b/tapset-utrace.cxx
> @@ -1208,6 +1208,12 @@ utrace_derived_probe_group::emit_module_linux_init (systemtap_session& s)
>      return;
>  
>    s.op->newline() << "/* ---- utrace probes ---- */";
> +  if (!flags_seen[UDPF_SYSCALL] && !flags_seen[UDPF_SYSCALL_RETURN])
> +    {
> +      s.op->newline() << "#if !defined(CONFIG_UTRACE)";
> +      s.op->newline() << "stap_utrace_only_vma_syscall_tracing();";
> +      s.op->newline() << "#endif";
> +    }

Will this be emitted if there are no utrace probes at all?

I think not, so perhaps the default should be flipped.  Assume filtered
syscalls by default, and let this code turn on the full mode if
process.syscall is in use.