From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29981 invoked by alias); 1 Jul 2016 16:56:26 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 29964 invoked by uid 89); 1 Jul 2016 16:56:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*i:sk:56e0c7f, H*MI:sk:56e0c7f, H*f:sk:56e0c7f X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 01 Jul 2016 16:56:24 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1E4C08E39C; Fri, 1 Jul 2016 16:56:23 +0000 (UTC) Received: from t540p.usersys.redhat.com (ovpn-116-51.rdu2.redhat.com [10.10.116.51]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u61GtqmY003509 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 1 Jul 2016 12:56:22 -0400 Subject: Re: SystemTap for Android - patchset To: Alexander Lochmann , systemtap@sourceware.org References: <56e0c7f4-d317-f76b-5156-3569a6097b62@tu-dortmund.de> From: David Smith Message-ID: <25f6a9ef-c089-03d3-5289-0feaac46becb@redhat.com> Date: Fri, 01 Jul 2016 16:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <56e0c7f4-d317-f76b-5156-3569a6097b62@tu-dortmund.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-q3/txt/msg00003.txt.bz2 On 07/01/2016 11:15 AM, Alexander Lochmann wrote: > > Hi folks! > > Finally, I decided to submit my patch, which makes SystemTap work for > Android. Moreover, it adds two new features: > - Support for ignoring all available tapset directories, except the one > that is provided by -K > - Support for a pid file in staprun, parameter is -U > I had to modify several source files of staprun. Those changes are > mostly copied from the corresponding files contained in commit > 2c10863bfe41b51272eff714a837f4977bdc257a. For some reasons, those ifdef > parts have been removed. I readded them, and changed the macro, which > activates them. > > The patch contains two bugfixes for the SystemTap as well. > Unfortunately, I failed to extract those fixes properly. :( > The first fix starts at line 510, and goes until line 555. > Since an older kernel like 3.0 does not support uprobes, systemtap > includes 'runtime/linux/task_finder_stubs.c'. That file itself does > *not* include 'syscall.h', which declares several syscall-related functions. > The second fix starts at line 1106. For some reasons in the Linux kernel > 3.0 the macro cputime_to_usecs() has a semicolon at the end of its > definition. Therefore, the defition of cputime_to_msecs() in ' > tapset/linux/task_time.stp' must be modified to deal with that fact. Alex, Thanks for working on this and sending us the patch. Is there any way to separate out the changes into one logical change per patch? Combining all the changes into one patch makes things quite hard to review. -- David Smith dsmith@redhat.com Red Hat http://www.redhat.com 256.217.0141 (direct) 256.837.0057 (fax)