From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32148 invoked by alias); 5 Dec 2011 14:09:52 -0000 Received: (qmail 32138 invoked by uid 22791); 5 Dec 2011 14:09:50 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,LOTS_OF_MONEY,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from devils.ext.ti.com (HELO devils.ext.ti.com) (198.47.26.153) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Dec 2011 14:09:34 +0000 Received: from dlep34.itg.ti.com ([157.170.170.115]) by devils.ext.ti.com (8.13.7/8.13.7) with ESMTP id pB5E9VZv027309 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 5 Dec 2011 08:09:31 -0600 Received: from dlep26.itg.ti.com (smtp-le.itg.ti.com [157.170.170.27]) by dlep34.itg.ti.com (8.13.7/8.13.8) with ESMTP id pB5E9VlM025091; Mon, 5 Dec 2011 08:09:31 -0600 (CST) Received: from DNCE73.ent.ti.com (localhost [127.0.0.1]) by dlep26.itg.ti.com (8.13.8/8.13.8) with ESMTP id pB5E9UQl017174; Mon, 5 Dec 2011 08:09:31 -0600 (CST) Received: from DNCE03.ent.ti.com ([fe80::19cb:d761:16a6:9b51]) by DNCE73.ent.ti.com ([fe80::a454:462:d009:b2c%21]) with mapi id 14.01.0323.003; Mon, 5 Dec 2011 15:09:30 +0100 From: "Turgis, Frederic" To: Mark Wielaard CC: SystemTap Subject: RE: "module privilege check" breaks (cross-)compilation due to libelf dependency Date: Mon, 05 Dec 2011 16:13:00 -0000 Message-ID: <28BE1A38672C8B4481BB423D0FD1F22E01BC14E6@DNCE03.ent.ti.com> References: <28BE1A38672C8B4481BB423D0FD1F22E01BC1426@DNCE03.ent.ti.com> <20111205135825.GF16831@hermans.wildebeest.org> In-Reply-To: <20111205135825.GF16831@hermans.wildebeest.org> x-exclaimer-md-config: f9c360f5-3d1e-4c3c-8703-f45bf52eff6b Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2011-q4/txt/msg00292.txt.bz2 Hi, After making few times the mistake to not check latest code, I ensure now t= o be on HEAD of master branch ;-) My feeling is that you had an environment with libelf available but elf_get= shdrstrndx() not available. This is then not sufficient but similar. This solves the issue of unused pa= rameters (this is a warning considered as an error) but not the issue of th= e use of Elf_Scn type. Systemtap only defines "typedef struct Elf_Scn Elf_S= cn;", real definition would come from "elfutils-0.143/libelf/libelfP.h" in = my case (but --with-elfutils is not used) Regards Fred Frederic Turgis OMAP Platform Business Unit - OMAP System Engineering - Platform Enablement= - System Multimedia > Texas Instruments France SA, 821 Avenue Jack Kilby, 06270 Villeneuve Loubet= . 036 420 040 R.C.S Antibes. Capital de EUR 753.920 -----Original Message----- >From: Mark Wielaard [mailto:mjw@redhat.com] >Sent: Monday, December 05, 2011 2:58 PM >To: Turgis, Frederic >Cc: SystemTap >Subject: Re: "module privilege check" breaks >(cross-)compilation due to libelf dependency > >On Mon, Dec 05, 2011 at 01:36:01PM +0000, Turgis, Frederic wrote: >> Commit "bb4470cacb3f7ce5161f9e8a1b7c37a87516a6c3 PR 13128: Implement >> module privilege check in staprun." has broken my cross-compilation >> environment to build "staprun" tool for ARM android (I do 4 first >> steps on host, staprun step on target), see end of mail. >> >> Having a deeper look, there is in fact code in staprun_funcs.c that >> requires libelf like find_section_in_module() and >> get_module_required_credentials() (Elf_Scn for example) and that is >> not surrounded by HAVE_LIBELF_H or HAVE_ELF_GETSHDRSTRNDX > >I had something similar a few days ago, though I don't >remember exactly which setup it was on. Does the following >commit help in your case? > >commit fa2418539b4ac2cb1352948f68da08890cec7774 >Author: Mark Wielaard >Date: Sat Nov 26 02:33:01 2011 +0100 > > Fix build error in staprun_funcs.c when >HAVE_ELF_GETSHDRSTRNDX is not set. > > Mark find_section_in_module arguments unused when >HAVE_ELF_GETSHDRSTRNDX > isn't set. > >Or do you need more than that? > >Cheers, > >Mark >