From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9789 invoked by alias); 5 Dec 2011 17:42:42 -0000 Received: (qmail 9699 invoked by uid 22791); 5 Dec 2011 17:42:40 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,LOTS_OF_MONEY,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from arroyo.ext.ti.com (HELO arroyo.ext.ti.com) (192.94.94.40) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Dec 2011 17:42:26 +0000 Received: from dlep36.itg.ti.com ([157.170.170.91]) by arroyo.ext.ti.com (8.13.7/8.13.7) with ESMTP id pB5HgP6i031501 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 5 Dec 2011 11:42:25 -0600 Received: from dlep26.itg.ti.com (smtp-le.itg.ti.com [157.170.170.27]) by dlep36.itg.ti.com (8.13.8/8.13.8) with ESMTP id pB5HgPsX013329; Mon, 5 Dec 2011 11:42:25 -0600 (CST) Received: from DNCE72.ent.ti.com (localhost [127.0.0.1]) by dlep26.itg.ti.com (8.13.8/8.13.8) with ESMTP id pB5HgOqH027256; Mon, 5 Dec 2011 11:42:24 -0600 (CST) Received: from DNCE03.ent.ti.com ([fe80::19cb:d761:16a6:9b51]) by DNCE72.ent.ti.com ([fe80::8e3:61e5:a5b9:593c%23]) with mapi id 14.01.0323.003; Mon, 5 Dec 2011 18:42:24 +0100 From: "Turgis, Frederic" To: Dave Brolley , "systemtap@sourceware.org" Subject: RE: "module privilege check" breaks (cross-)compilation due to libelf dependency Date: Tue, 06 Dec 2011 08:40:00 -0000 Message-ID: <28BE1A38672C8B4481BB423D0FD1F22E01BC17E1@DNCE03.ent.ti.com> References: <28BE1A38672C8B4481BB423D0FD1F22E01BC1426@DNCE03.ent.ti.com> <20111205135825.GF16831@hermans.wildebeest.org> <28BE1A38672C8B4481BB423D0FD1F22E01BC14E6@DNCE03.ent.ti.com> <4EDCED8C.6040908@redhat.com> In-Reply-To: <4EDCED8C.6040908@redhat.com> x-exclaimer-md-config: f9c360f5-3d1e-4c3c-8703-f45bf52eff6b Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2011-q4/txt/msg00295.txt.bz2 Thanks, my first mail points to code that broke on my environment, still I = do not know all the goals of the code so could not provide more complete/cl= ean stuff. Regards Fred Frederic Turgis OMAP Platform Business Unit - OMAP System Engineering - Platform Enablement= - System Multimedia > Texas Instruments France SA, 821 Avenue Jack Kilby, 06270 Villeneuve Loubet= . 036 420 040 R.C.S Antibes. Capital de EUR 753.920 -----Original Message----- >From: systemtap-owner@sourceware.org >[mailto:systemtap-owner@sourceware.org] On Behalf Of Dave Brolley >Sent: Monday, December 05, 2011 5:13 PM >To: systemtap@sourceware.org >Subject: Re: "module privilege check" breaks >(cross-)compilation due to libelf dependency > >Hi, > >Sorry for this. I'll re-examine the code to make sure it >builds in all environments. > >Dave > >On 12/05/2011 09:09 AM, Turgis, Frederic wrote: >> Hi, >> >> After making few times the mistake to not check latest code, >I ensure >> now to be on HEAD of master branch ;-) >> >> My feeling is that you had an environment with libelf >available but elf_getshdrstrndx() not available. >> >> This is then not sufficient but similar. This solves the issue of >> unused parameters (this is a warning considered as an error) but not >> the issue of the use of Elf_Scn type. Systemtap only defines >"typedef >> struct Elf_Scn Elf_Scn;", real definition would come from >> "elfutils-0.143/libelf/libelfP.h" in my case (but --with-elfutils is >> not used) >> >> >> >> Regards >> Fred >> >> Frederic Turgis >> OMAP Platform Business Unit - OMAP System Engineering - Platform >> Enablement - System Multimedia >> >> >> >> Texas Instruments France SA, 821 Avenue Jack Kilby, 06270 Villeneuve >> Loubet. 036 420 040 R.C.S Antibes. Capital de EUR 753.920 >> >> -----Original Message----- >>> From: Mark Wielaard [mailto:mjw@redhat.com] >>> Sent: Monday, December 05, 2011 2:58 PM >>> To: Turgis, Frederic >>> Cc: SystemTap >>> Subject: Re: "module privilege check" breaks >(cross-)compilation due >>> to libelf dependency >>> >>> On Mon, Dec 05, 2011 at 01:36:01PM +0000, Turgis, Frederic wrote: >>>> Commit "bb4470cacb3f7ce5161f9e8a1b7c37a87516a6c3 PR 13128: >Implement >>>> module privilege check in staprun." has broken my >cross-compilation >>>> environment to build "staprun" tool for ARM android (I do 4 first >>>> steps on host, staprun step on target), see end of mail. >>>> >>>> Having a deeper look, there is in fact code in >staprun_funcs.c that >>>> requires libelf like find_section_in_module() and >>>> get_module_required_credentials() (Elf_Scn for example) >and that is >>>> not surrounded by HAVE_LIBELF_H or HAVE_ELF_GETSHDRSTRNDX >>> I had something similar a few days ago, though I don't remember >>> exactly which setup it was on. Does the following commit >help in your >>> case? >>> >>> commit fa2418539b4ac2cb1352948f68da08890cec7774 >>> Author: Mark Wielaard >>> Date: Sat Nov 26 02:33:01 2011 +0100 >>> >>> Fix build error in staprun_funcs.c when HAVE_ELF_GETSHDRSTRNDX is >>> not set. >>> >>> Mark find_section_in_module arguments unused when >>> HAVE_ELF_GETSHDRSTRNDX >>> isn't set. >>> >>> Or do you need more than that? >>> >>> Cheers, >>> >>> Mark >>> >