Re: [RFC] Enhanced Garbage Collection Probe Points

[Jon VanAlten <jvanalte@redhat.com>]

----- Original Message -----
> From: "Andrew Hughes" <gnu.andrew@redhat.com>

<SNIP>

> > > 
> > > Why has this been pushed?  We don't want more patches adding to
> > > IcedTea7.
> > > Please revert.
> > > 
> > 
> > I'm sorry for the mix-up.  Andrew and I discussed this further
> > offline (sorry, this did not happen in public, but neither was it
> > intentionally private).
> > 
> > We reached the conclusion (I believe) that it would be best to
> > wait and hear from Mark about plans referred to in email archive
> > link below.  Mark, do you have any comment here?  Would it be
> > for the best to revert here and apply instead to 7 forest?
> > 
> > Also, I've backported this changeset to icedtea6, and it should
> > also probably go somehow to 8.  Can someone refresh me, as a
> > rather seldom-contributor here, what the correct repos are for
> > these?
> > 
> 
> Patch needs to be applied to:
> 
> http://icedtea.classpath.org/hg/icedtea6/
> http://icedtea.classpath.org/hg/icedtea7-forest/jdk/
> http://icedtea.classpath.org/hg/icedtea8-forest/jdk/
> 
> and reverted from:
> 
> http://icedtea.classpath.org/hg/icedtea7/
> 
> as all patches for 7 & 8 go to the forest.
> 

I would also prefer the 7 stuff to go to the forest, but...

> From: "Mark Wielaard" <mark@klomp.org>

<SNIP>

> 
> Adding patches directly to the tree is fine with me.
> My only hesitation was my own confusion since the default
> configure/make setup doesn't pick up a patched forest.
> You don't have that issue with patches, which are directly
> applied. If we are going for a complete forest setup it
> might make sense to also add the tapsets and testsuite
> directly there.
> 
> I'll try and figure it all out again and also port the existing
> patches to the forest. Hints and tips appreciated.

So about this patch and 7, I'm getting mixed messages here.

Some other things to consider here:

The new work from Lukas can be conceptually divided into two
parts: the new probes added to hotspot code, and the tapset
referring to those probes.  The thing is, the probes are not
afaik usable from linux (my dev/testing platform) without some
parts of Mark's patches.  For this reason, I'm hesitant to port
and push Lukas' work to forest, ahead of Mark's (it becomes
essentially dead code except on Solaris).  So, would it be
acceptable to keep in tree for now, porting to 7/8 forests
later once the prerequisite bits have been ported?

(in the meantime, I *have* ported to 6 tree and pushed that,
since there is no controversy there...)

cheers,
jon