From: David Smith <dsmith@redhat.com>
To: Alexander Lochmann <alexander.lochmann@tu-dortmund.de>,
Josh Stone <jistone@redhat.com>,
systemtap@sourceware.org
Subject: Re: SystemTap for Android - patchset
Date: Thu, 07 Jul 2016 17:39:00 -0000 [thread overview]
Message-ID: <3b77fcde-cf56-6c70-0c38-b1dbe7d5f37f@redhat.com> (raw)
In-Reply-To: <577E81DA.2@tu-dortmund.de>
On 07/07/2016 11:22 AM, Alexander Lochmann wrote:
> On 07.07.2016 18:06, David Smith wrote:
>> On 07/06/2016 07:29 AM, Alexander Lochmann wrote:
>>> So. Let me start.
>>> First of all, I extracted the patches properly, and attached the files.
>>> (Btw, I found a third bug. :) )
>>> FYI, I just fixed the bugs for the kernel versions I'm dealing with,
>>> because I don't know which other versions are affected as well.
>>
>> Looking at your 2nd patch, '[PATCH 2/3] The syscall defines were not
>> compatible with older kernels, namely 3.0.x', this bit doesn't seem
>> correct at all:
>>
>> ====
>> diff --git a/runtime/linux/autoconf-asm-syscall.c
>> b/runtime/linux/autoconf-asm-syscall.c
>> index bf7a273..6bfcd55 100644
>> --- a/runtime/linux/autoconf-asm-syscall.c
>> +++ b/runtime/linux/autoconf-asm-syscall.c
>> @@ -1,2 +1,8 @@
>> +#include <linux/version.h>
>> +#if LINUX_VERSION_CODE <= KERNEL_VERSION(3,0,200) && LINUX_VERSION_CODE
>>> = KERNEL_VERSION(3,0,0)
>> +#include <asm/unistd.h>
>> +#include <linux/sched.h>
>> +#include <asm-generic/syscall.h>
>> +#else
>> #include <asm/syscall.h>
>> -
>> +#endif
>> ====
>>
>> Including <asm-generic/syscall.h> is highly suspicious. Did you try to
>> include <asm/syscall.h> and get errors? If so, we can work to fix those
>> errors. Not including your arch's real syscall.h file will cause errors
>> down the road.
>>
> An arch-specific syscall.h does not exist for arm. :(
> The kernel tree for both the Galaxy Nexus (maguro) and the Nexus 4 do
> not have a syscall.h (path: arch/arm/include/asm/syscall.h does not exist).
OK, I'll believe you. However, your fix above still isn't correct. The
whole point of autoconf-asm-syscall.c is to test if asm/syscall.h exists
and is usable. If so, STAPCONF_ASM_SYSCALL_H will get defined. If
autoconf-asm-syscall.c doesn't compile correctly, then
STAPCONF_ASM_SYSCALL_H won't be defined.
What needs to happen next here is for you to back out this change,
recompile systemtap, then try to compile a few systemtap scripts. We'll
need to see the errors to know what to fix. I'd guess we'll need to test
STAPCONF_ASM_SYSCALL_H in some more places.
--
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)
next prev parent reply other threads:[~2016-07-07 17:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f01a1f27-3cdb-61a4-cbdb-7bffd1032c8e@tu-dortmund.de>
2016-07-01 16:15 ` Alexander Lochmann
2016-07-01 16:56 ` David Smith
2016-07-01 17:47 ` Josh Stone
2016-07-06 12:29 ` Alexander Lochmann
2016-07-06 16:42 ` Frank Ch. Eigler
2016-07-06 20:05 ` Alexander Lochmann
2016-07-06 20:15 ` Frank Ch. Eigler
2016-07-06 20:27 ` Alexander Lochmann
2016-07-07 16:00 ` David Smith
2016-07-07 16:06 ` David Smith
2016-07-07 16:23 ` Alexander Lochmann
2016-07-07 17:39 ` David Smith [this message]
2016-07-07 20:51 ` Alexander Lochmann
2016-07-07 21:14 ` David Smith
2016-07-08 5:38 ` Alexander Lochmann
2016-07-08 15:31 ` David Smith
2016-07-07 18:47 ` David Smith
2016-07-07 19:01 ` Alexander Lochmann
2016-07-07 19:24 ` David Smith
2016-07-07 19:32 ` Alexander Lochmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b77fcde-cf56-6c70-0c38-b1dbe7d5f37f@redhat.com \
--to=dsmith@redhat.com \
--cc=alexander.lochmann@tu-dortmund.de \
--cc=jistone@redhat.com \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).