From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41431 invoked by alias); 7 Jul 2016 17:39:39 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 41419 invoked by uid 89); 7 Jul 2016 17:39:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*MI:sk:577E81D, H*f:sk:577E81D, H*i:sk:577E81D, Hx-languages-length:2287 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 07 Jul 2016 17:39:36 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EE47BC6A19; Thu, 7 Jul 2016 17:39:34 +0000 (UTC) Received: from t540p.usersys.redhat.com ([10.15.1.231]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u67HdYGE008055 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 7 Jul 2016 13:39:34 -0400 Subject: Re: SystemTap for Android - patchset To: Alexander Lochmann , Josh Stone , systemtap@sourceware.org References: <56e0c7f4-d317-f76b-5156-3569a6097b62@tu-dortmund.de> <577CF9A2.7050008@tu-dortmund.de> <41638913-446d-4b2e-7fab-cfdeeca6170a@redhat.com> <577E81DA.2@tu-dortmund.de> From: David Smith Message-ID: <3b77fcde-cf56-6c70-0c38-b1dbe7d5f37f@redhat.com> Date: Thu, 07 Jul 2016 17:39:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <577E81DA.2@tu-dortmund.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-q3/txt/msg00020.txt.bz2 On 07/07/2016 11:22 AM, Alexander Lochmann wrote: > On 07.07.2016 18:06, David Smith wrote: >> On 07/06/2016 07:29 AM, Alexander Lochmann wrote: >>> So. Let me start. >>> First of all, I extracted the patches properly, and attached the files. >>> (Btw, I found a third bug. :) ) >>> FYI, I just fixed the bugs for the kernel versions I'm dealing with, >>> because I don't know which other versions are affected as well. >> >> Looking at your 2nd patch, '[PATCH 2/3] The syscall defines were not >> compatible with older kernels, namely 3.0.x', this bit doesn't seem >> correct at all: >> >> ==== >> diff --git a/runtime/linux/autoconf-asm-syscall.c >> b/runtime/linux/autoconf-asm-syscall.c >> index bf7a273..6bfcd55 100644 >> --- a/runtime/linux/autoconf-asm-syscall.c >> +++ b/runtime/linux/autoconf-asm-syscall.c >> @@ -1,2 +1,8 @@ >> +#include >> +#if LINUX_VERSION_CODE <= KERNEL_VERSION(3,0,200) && LINUX_VERSION_CODE >>> = KERNEL_VERSION(3,0,0) >> +#include >> +#include >> +#include >> +#else >> #include >> - >> +#endif >> ==== >> >> Including is highly suspicious. Did you try to >> include and get errors? If so, we can work to fix those >> errors. Not including your arch's real syscall.h file will cause errors >> down the road. >> > An arch-specific syscall.h does not exist for arm. :( > The kernel tree for both the Galaxy Nexus (maguro) and the Nexus 4 do > not have a syscall.h (path: arch/arm/include/asm/syscall.h does not exist). OK, I'll believe you. However, your fix above still isn't correct. The whole point of autoconf-asm-syscall.c is to test if asm/syscall.h exists and is usable. If so, STAPCONF_ASM_SYSCALL_H will get defined. If autoconf-asm-syscall.c doesn't compile correctly, then STAPCONF_ASM_SYSCALL_H won't be defined. What needs to happen next here is for you to back out this change, recompile systemtap, then try to compile a few systemtap scripts. We'll need to see the errors to know what to fix. I'd guess we'll need to test STAPCONF_ASM_SYSCALL_H in some more places. -- David Smith dsmith@redhat.com Red Hat http://www.redhat.com 256.217.0141 (direct) 256.837.0057 (fax)