Re: SystemTap for Android - patchset

[David Smith <dsmith@redhat.com>]

On 07/06/2016 07:29 AM, Alexander Lochmann wrote:
> So. Let me start.
> First of all, I extracted the patches properly, and attached the files.
> (Btw, I found a third bug. :) )
> FYI, I just fixed the bugs for the kernel versions I'm dealing with,
> because I don't know which other versions are affected as well.

Looking at your 2nd patch, '[PATCH 2/3] The syscall defines were not
compatible with older kernels, namely 3.0.x', this bit doesn't seem
correct at all:

====
diff --git a/runtime/linux/autoconf-asm-syscall.c
b/runtime/linux/autoconf-asm-syscall.c
index bf7a273..6bfcd55 100644
--- a/runtime/linux/autoconf-asm-syscall.c
+++ b/runtime/linux/autoconf-asm-syscall.c
@@ -1,2 +1,8 @@
+#include <linux/version.h>
+#if LINUX_VERSION_CODE <= KERNEL_VERSION(3,0,200) && LINUX_VERSION_CODE
>= KERNEL_VERSION(3,0,0)
+#include <asm/unistd.h>
+#include <linux/sched.h>
+#include <asm-generic/syscall.h>
+#else
 #include <asm/syscall.h>
-
+#endif
====

Including <asm-generic/syscall.h> is highly suspicious. Did you try to
include <asm/syscall.h> and get errors? If so, we can work to fix those
errors. Not including your arch's real syscall.h file will cause errors
down the road.

-- 
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)