public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: William Cohen <wcohen@redhat.com>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: systemtap@sources.redhat.com
Subject: Re: prompt script exiting
Date: Mon, 12 Dec 2005 20:22:00 -0000	[thread overview]
Message-ID: <439DDC11.2060908@redhat.com> (raw)
In-Reply-To: <20051212154947.GM20633@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 841 bytes --]

Frank Ch. Eigler wrote:
> Hi -
> 
> wcohen wrote:
> 
> 
>>That [systemtap_session change] sounds like it would operate in the
>>manner that people would expect. [...]
> 
> 
> Yeah.  Would you mind testing it and committing it if it works?
> 
> 
>>What happens if there are two scripts running? Is this flag local to
>>the script or a global? [...]
> 
> 
> "global" in the systemtap sense means shared amongst probe handlers of
> the same systemtap session.  There is no "global" data in the sense of
> kernel-wide at all, except perhaps in kprobes internals.
> 
> - FChE

Here is a one-liner that appears to fix the problem. 
systemtap.samples/syscalls2.exp works when it is installed.

2005-12-12  Will Cohen  <wcohen@redhat.com>

	* tapset/logging.stp (function_exit): Make sure systemtap
	probes stop collection additional data.



-Will

[-- Attachment #2: quickstop.patch --]
[-- Type: text/x-patch, Size: 477 bytes --]

Index: logging.stp
===================================================================
RCS file: /cvs/systemtap/src/tapset/logging.stp,v
retrieving revision 1.6
diff -u -r1.6 logging.stp
--- logging.stp	18 Nov 2005 21:57:30 -0000	1.6
+++ logging.stp	12 Dec 2005 20:16:34 -0000
@@ -21,6 +21,7 @@
 
 // NB: exit() does *not* cause immediate return from current function/probe
 function exit () %{
+    atomic_set (&session_state, STAP_SESSION_STOPPING);
     _stp_exit ();
 %}
 

  reply	other threads:[~2005-12-12 20:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-12 11:35 Mao, Bibo
2005-12-12 15:26 ` Frank Ch. Eigler
2005-12-12 15:42   ` William Cohen
2005-12-12 15:49     ` Frank Ch. Eigler
2005-12-12 20:22       ` William Cohen [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-12-02 20:08 William Cohen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=439DDC11.2060908@redhat.com \
    --to=wcohen@redhat.com \
    --cc=fche@redhat.com \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).