From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7283 invoked by alias); 12 Dec 2005 20:22:48 -0000 Received: (qmail 7223 invoked by uid 22791); 12 Dec 2005 20:22:46 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 12 Dec 2005 20:22:43 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id jBCKMfHB012174 for ; Mon, 12 Dec 2005 15:22:41 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id jBCKMf122328; Mon, 12 Dec 2005 15:22:41 -0500 Received: from [172.16.59.162] (dhcp59-162.rdu.redhat.com [172.16.59.162]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id jBCKMf9O023334; Mon, 12 Dec 2005 15:22:41 -0500 Message-ID: <439DDC11.2060908@redhat.com> Date: Mon, 12 Dec 2005 20:22:00 -0000 From: William Cohen User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Frank Ch. Eigler" CC: systemtap@sources.redhat.com Subject: Re: prompt script exiting References: <9FBCE015AF479F46B3B410499F3AE05B08981C@pdsmsx405> <439D9A5C.1020705@redhat.com> <20051212154947.GM20633@redhat.com> In-Reply-To: <20051212154947.GM20633@redhat.com> Content-Type: multipart/mixed; boundary="------------090803010306000401030400" X-Virus-Checked: Checked by ClamAV on sourceware.org X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2005-q4/txt/msg00413.txt.bz2 This is a multi-part message in MIME format. --------------090803010306000401030400 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 841 Frank Ch. Eigler wrote: > Hi - > > wcohen wrote: > > >>That [systemtap_session change] sounds like it would operate in the >>manner that people would expect. [...] > > > Yeah. Would you mind testing it and committing it if it works? > > >>What happens if there are two scripts running? Is this flag local to >>the script or a global? [...] > > > "global" in the systemtap sense means shared amongst probe handlers of > the same systemtap session. There is no "global" data in the sense of > kernel-wide at all, except perhaps in kprobes internals. > > - FChE Here is a one-liner that appears to fix the problem. systemtap.samples/syscalls2.exp works when it is installed. 2005-12-12 Will Cohen * tapset/logging.stp (function_exit): Make sure systemtap probes stop collection additional data. -Will --------------090803010306000401030400 Content-Type: text/x-patch; name="quickstop.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="quickstop.patch" Content-length: 477 Index: logging.stp =================================================================== RCS file: /cvs/systemtap/src/tapset/logging.stp,v retrieving revision 1.6 diff -u -r1.6 logging.stp --- logging.stp 18 Nov 2005 21:57:30 -0000 1.6 +++ logging.stp 12 Dec 2005 20:16:34 -0000 @@ -21,6 +21,7 @@ // NB: exit() does *not* cause immediate return from current function/probe function exit () %{ + atomic_set (&session_state, STAP_SESSION_STOPPING); _stp_exit (); %} --------------090803010306000401030400--