From: Masami Hiramatsu <hiramatu@sdl.hitachi.co.jp>
To: ananth@in.ibm.com
Cc: maneesh@in.ibm.com, anil.s.keshavamurthy@intel.com,
systemtap@sources.redhat.com,
Satoshi Oshima <soshima@redhat.com>,
Hideo Aoki <haoki@redhat.com>,
Yumiko Sugita <sugita@sdl.hitachi.co.jp>
Subject: Re: [RFC][Patch 1/2][take3]kprobe: kprobe-booster against 2.6.15-rc5-mm3 for i386
Date: Tue, 24 Jan 2006 13:22:00 -0000 [thread overview]
Message-ID: <43D62A36.6010406@sdl.hitachi.co.jp> (raw)
In-Reply-To: <20060124070433.GA3607@in.ibm.com>
Hi, Ananth
Ananth N Mavinakayanahalli wrote:
> On Thu, Dec 22, 2005 at 10:23:56PM +0900, Masami Hiramatsu wrote:
>
>>Hi,
>>
>>Here is a patch to clean up kprobe's resume_execute() for i386 arch.
>>Before applying kprobe-booster, I'd like to cleanup codes.
>>It is useful for simplify booster patch.
>
> Hi Masami,
>
> This patch looks fine except for some coding-style issues (^^^ below).
Thank you for review. I will fix those coding style issues.
>>+
>>+ no_change:
> ^^^^ no spaces for goto labels.
>
>
>>+ return ;
> ^^^ spurious whitespace
Then, here is OK?
---
no_change:
return;
---
--
Masami HIRAMATSU
2nd Research Dept.
Hitachi, Ltd., Systems Development Laboratory
E-mail: hiramatu@sdl.hitachi.co.jp
next prev parent reply other threads:[~2006-01-24 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-22 13:24 Masami Hiramatsu
2006-01-24 7:04 ` Ananth N Mavinakayanahalli
2006-01-24 13:22 ` Masami Hiramatsu [this message]
2006-01-24 14:16 ` Masami Hiramatsu
2006-01-25 4:51 ` Ananth N Mavinakayanahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43D62A36.6010406@sdl.hitachi.co.jp \
--to=hiramatu@sdl.hitachi.co.jp \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=haoki@redhat.com \
--cc=maneesh@in.ibm.com \
--cc=soshima@redhat.com \
--cc=sugita@sdl.hitachi.co.jp \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).