From: Masami Hiramatsu <hiramatu@sdl.hitachi.co.jp>
To: Andrew Morton <akpm@osdl.org>
Cc: ananth@in.ibm.com, prasanna@in.ibm.com,
anil.s.keshavamurthy@intel.com,
systemtap@sources.redhat.com, jkenisto@us.ibm.com,
linux-kernel@vger.kernel.org, sugita@sdl.hitachi.co.jp,
soshima@redhat.com, haoki@redhat.com
Subject: Re: [PATCH][take2][2/2] kprobe: kprobe-booster against 2.6.16-rc5 for i386
Date: Tue, 28 Feb 2006 06:07:00 -0000 [thread overview]
Message-ID: <4403E894.4050300@sdl.hitachi.co.jp> (raw)
In-Reply-To: <20060227185012.037c8830.akpm@osdl.org>
Hi, Andrew
Andrew Morton wrote:
> Masami Hiramatsu <hiramatu@sdl.hitachi.co.jp> wrote:
>> Here is a patch of kprobe-booster for i386 arch against linux-2.6.16-rc5.
>> The kprobe-booster patch is also under the influence of the NX-protection
>> support patch. So, I fixed that.
>>
>> Could you replace the previous patches with these patches?
>
> I'd prefer not to. Once a patch has been in -mm for this long I really
> prefer to not see wholesale replacements. When people do this to me I
> usually turn their replacements into incremental patches so we can see what
> changed. Which is useful.
>
> Your first patch was identical to what I already have, so I dropped that.
Thank you for your advice. I will re-create an additional patch
against recent -mm tree.
> Your second patch made these changes:
>
> --- devel/arch/i386/kernel/kprobes.c~kprobe-kprobe-booster-against-2616-rc5-for 2006-02-27 18:40:29.000000000 -0800
> +++ devel-akpm/arch/i386/kernel/kprobes.c 2006-02-27 18:40:57.000000000 -0800
> @@ -305,7 +305,7 @@ static int __kprobes kprobe_handler(stru
>
> if (p->ainsn.boostable == 1 &&
> #ifdef CONFIG_PREEMPT
> - !(pre_preempt_count) && /*
> + !(pre_preempt_count()) && /*
> * This enables booster when the direct
> * execution path aren't preempted.
> */
> @@ -313,7 +313,7 @@ static int __kprobes kprobe_handler(stru
> !p->post_handler && !p->break_handler ) {
> /* Boost up -- we can execute copied instructions directly */
> reset_current_kprobe();
> - regs->eip = (unsigned long)&p->ainsn.insn;
> + regs->eip = (unsigned long)p->ainsn.insn;
> preempt_enable_no_resched();
> return 1;
> }
>
> The first hunk is surely wrong - pre_preempt_count is a local unsigned
> integer, not a function.
I'm sorry. It's my fault. The first hunk is just a degradation.
> And I'm not sure about the second hunk either - surely an `eip' should
> point at an instruction, not be assigned the value of an instruction?
This change is important. Because NX-protection support patch makes
the ainsn.insn a pointer instead of a data structure, so now (&p->ainsn.insn)
means just an address of the pointer -- not the instruction address.
> So I'll drop both patches. If you have bugfixes, please make them relative
> to already-merged things. Against most-recent -mm is best, as I do fix
> patches up, and other people send fixes which you might not have merged
> locally. And please ensure that the changes compile and run with and
> without CONFIG_PREEMPT!
OK. I will get the latest -mm tree and test it.
And I will re-send the patch ASAP.
--
Masami HIRAMATSU
2nd Research Dept.
Hitachi, Ltd., Systems Development Laboratory
E-mail: hiramatu@sdl.hitachi.co.jp
next prev parent reply other threads:[~2006-02-28 6:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-30 12:44 [PATCH][2/2] kprobe: kprobe-booster against 2.6.16-rc1 " Masami Hiramatsu
2006-01-31 0:42 ` Masami Hiramatsu
[not found] ` <20060131145053.235e27e4.akpm@osdl.org>
2006-02-01 13:02 ` Masami Hiramatsu
2006-02-27 11:57 ` [PATCH][take2][2/2] kprobe: kprobe-booster against 2.6.16-rc5 " Masami Hiramatsu
[not found] ` <20060227185012.037c8830.akpm@osdl.org>
2006-02-28 6:07 ` Masami Hiramatsu [this message]
2006-03-01 4:41 ` [PATCH] kprobe: kprobe-booster fix for NX support on i386 Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4403E894.4050300@sdl.hitachi.co.jp \
--to=hiramatu@sdl.hitachi.co.jp \
--cc=akpm@osdl.org \
--cc=ananth@in.ibm.com \
--cc=anil.s.keshavamurthy@intel.com \
--cc=haoki@redhat.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=prasanna@in.ibm.com \
--cc=soshima@redhat.com \
--cc=sugita@sdl.hitachi.co.jp \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).