From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <systemtap-return-2736-listarch-systemtap=sources.redhat.com@sourceware.org>
Received: (qmail 1654 invoked by alias); 7 Mar 2006 22:24:06 -0000
Received: (qmail 1645 invoked by uid 22791); 7 Mar 2006 22:24:05 -0000
X-Spam-Status: No, hits=-2.1 required=5.0 	tests=AWL,BAYES_00,DNS_FROM_RFC_ABUSE,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from e36.co.us.ibm.com (HELO e36.co.us.ibm.com) (32.97.110.154)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 07 Mar 2006 22:24:02 +0000
Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) 	by e36.co.us.ibm.com (8.12.11/8.12.11) with ESMTP id k27MO1W5026564 	for <systemtap@sources.redhat.com>; Tue, 7 Mar 2006 17:24:01 -0500
Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) 	by d03relay04.boulder.ibm.com (8.12.10/NCO/VER6.8) with ESMTP id k27MQnLf179160 	for <systemtap@sources.redhat.com>; Tue, 7 Mar 2006 15:26:49 -0700
Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1]) 	by d03av01.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id k27MNx22011854 	for <systemtap@sources.redhat.com>; Tue, 7 Mar 2006 15:23:59 -0700
Received: from [9.47.22.138] (dyn9047022138.beaverton.ibm.com [9.47.22.138]) 	by d03av01.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id k27MNwjp011817; 	Tue, 7 Mar 2006 15:23:58 -0700
Message-ID: <440E07FE.2060804@us.ibm.com>
Date: Tue, 07 Mar 2006 22:24:00 -0000
From: Hien Nguyen <hien@us.ibm.com>
User-Agent: Mozilla Thunderbird 1.0.7-1.1.fc4 (X11/20050929)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Keshavamurthy Anil S <anil.s.keshavamurthy@intel.com>
CC: Prasanna S Panchamukhi <prasanna@in.ibm.com>, systemtap@sources.redhat.com
Subject: Re: [1/5 PATCH] Kprobes fix for broken fault handling for i386
References: <20060307133832.GA2245@in.ibm.com> <20060307132608.A29873@unix-os.sc.intel.com>
In-Reply-To: <20060307132608.A29873@unix-os.sc.intel.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:systemtap-subscribe@sourceware.org>
List-Post: <mailto:systemtap@sourceware.org>
List-Help: <mailto:systemtap-help@sourceware.org>, <http://sourceware.org/lists.html#faqs>
Sender: systemtap-owner@sourceware.org
X-SW-Source: 2006-q1/txt/msg00730.txt.bz2

Keshavamurthy Anil S wrote:

>On Tue, Mar 07, 2006 at 05:38:32AM -0800, Prasanna S Panchamukhi wrote:
>  
>
>>   Hi,
>>
>>   Below is the set of patches to fix broken fault handling
>>   for i386, x86_64, ppc64, ia64 and sparc64 architectures
>>   against 2.6.16-rc5-mm2.
>>
>>   These patches are tested for i386 and x86_64 architectures.
>>   Could you please test it for ia64 and ppc64.
>>    
>>
>
>Prasanna,
>	Can you share your test module code here,
>so that the same can be used(with minor tweak, if requred)
>for testing other architecture. Also in you testing, did 
>you cover fault handling during pre/post/singlestep
>cases?
>
>Thanks,
>Anil
>
>  
>
I tested Prasanna's fault handling patch with the current syscalls 
tapset (latest from CVS) which does lots of user copies. Without the 
patch the system crashes right away, but with this patch I finally can 
test the system calls tapset.

I use Martin's sys.stp script below

probe syscall.*, syscall.*.return {
        if (pid() == target()) {
                if (returnp)
                        printf("%d\n", returnval())
                else
                        printf("%s (%s) = ", name, argstr)
        }
}

Invoke the script as follow
stap -c bash sys.stp
to exit the script, just type exit.

Hien.