From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17389 invoked by alias); 3 Apr 2006 09:24:36 -0000 Received: (qmail 17381 invoked by uid 22791); 3 Apr 2006 09:24:36 -0000 X-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from mga05.intel.com (HELO fmsmga101.fm.intel.com) (192.55.52.89) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 03 Apr 2006 09:24:35 +0000 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 03 Apr 2006 02:24:33 -0700 Received: from maobb.sh.intel.com (HELO [10.239.13.78]) ([10.239.13.78]) by fmsmga001.fm.intel.com with ESMTP; 03 Apr 2006 02:24:32 -0700 TrustExchangeSourcedMail: True X-ExchangeTrusted: True X-IronPort-AV: i="4.03,156,1141632000"; d="scan'208"; a="19066790:sNHT17771880" Message-ID: <4430E75E.5090204@linux.intel.com> Date: Mon, 03 Apr 2006 09:24:00 -0000 From: bibo mao User-Agent: Thunderbird 1.5 (X11/20051201) MIME-Version: 1.0 To: Li Guanglei CC: "Mao, Bibo" , systemtap Subject: Re: patch for module function probe References: <9FBCE015AF479F46B3B410499F3AE05BEDA977@pdsmsx405> <4430E569.8050904@cn.ibm.com> In-Reply-To: <4430E569.8050904@cn.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q2/txt/msg00009.txt.bz2 If it is designed feature, then kernel.function("foo") will be regarded as module("kernel").function("foo"). But if there is one module named "kernel.ko", how to probe its function although its module name is weird? In another way to say what is the meaning of module("kernel").function("foo"), else stap manual clarify that module("kernel") means kernel image, user had better not use the same module name. Li Guanglei wrote: > Mao, Bibo : >> Hi, >> Currently systemtap has some problem when searching module >> function, which is reported in >> http://sourceware.org/ml/systemtap/2006-q1/msg00674.html. Kernel is >> treated as one module whose name is TOK_KERNEL "kernel". So this script >> will pass to compile, it indeed will probe kernel function: >> probe module("kernel").function("sys_read"){ >> } >> But there will be problem when there is actually one module named >> kernel.ko though its name is weird. >> >> Bibo,mao >> > Actually, I think the expansion of module("*").function("foo") into > kernel.function("foo") is a designed feature. It is especially useful > for those compiled-in kernel modules. For example, in LKET, I can use: > > probe addevent.scsi.iodispatching > = module("*").function("scsi_dispatch_cmd@drivers/scsi/scsi.c") > > to let LKET work despite scsi_mod being compiled as a module or into the > kernel. > > >