From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3056 invoked by alias); 15 Jul 2006 06:20:25 -0000 Received: (qmail 3049 invoked by uid 22791); 15 Jul 2006 06:20:24 -0000 X-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,UNPARSEABLE_RELAY X-Spam-Check-By: sourceware.org Received: from mail8.hitachi.co.jp (HELO mail8.hitachi.co.jp) (133.145.228.43) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 15 Jul 2006 06:20:20 +0000 Received: from mlsv7.hitachi.co.jp (unknown [133.145.228.16]) by mail8.hitachi.co.jp (Postfix) with ESMTP id 082F537C9A for ; Sat, 15 Jul 2006 15:20:17 +0900 (JST) Received: from mfilter-s3.hitachi.co.jp by mlsv7.hitachi.co.jp (8.12.11/8.12.11) id k6F6KGUC021382; Sat, 15 Jul 2006 15:20:16 +0900 Received: from vshuts2.hitachi.co.jp (unverified) by mfilter-s3.hitachi.co.jp (Content Technologies SMTPRS 4.3.17) with SMTP id ; Sat, 15 Jul 2006 15:20:16 +0900 Received: from hsdlgw92.sdl.hitachi.co.jp ([133.144.7.20]) by vshuts2.hitachi.co.jp with SMTP id M2006071515201626056 ; Sat, 15 Jul 2006 15:20:16 +0900 Received: from vgate2.sdl.hitachi.co.jp by hsdlgw92.sdl.hitachi.co.jp (8.9.3/3.7W06061314) id PAA24378; Sat, 15 Jul 2006 15:20:15 +0900 Received: from maila.sdl.hitachi.co.jp ([133.144.14.196]) by vgate2.sdl.hitachi.co.jp (SAVSMTP 3.1.1.32) with SMTP id M2006071515201529256 ; Sat, 15 Jul 2006 15:20:15 +0900 Received: from [127.0.0.1] ([10.232.9.172]) by maila.sdl.hitachi.co.jp (8.13.1/3.7W04031011) with ESMTP id k6F6KEnC009910; Sat, 15 Jul 2006 15:20:15 +0900 Message-ID: <44B888FD.9020505@hitachi.com> Date: Sat, 15 Jul 2006 06:20:00 -0000 From: Masami Hiramatsu Organization: Systems Development Lab., Hitachi, Ltd., Japan User-Agent: Thunderbird 1.5.0.2 (Windows/20060308) MIME-Version: 1.0 To: Keshavamurthy Anil S Cc: Ananth N Mavinakayanahalli , SystemTAP , Yumiko Sugita , Satoshi Oshima , Hideo Aoki , Prasanna S Panchamukhi , Jim Keniston Subject: Re: Preemption-safe kprobe-booster(Re: [PATCH]kprobe booster for IA64) References: <4485223C.8090109@sdl.hitachi.co.jp> <20060628190541.A13874@unix-os.sc.intel.com> <44AAF207.7090908@sdl.hitachi.co.jp> <44B4952D.9010603@hitachi.com> <20060712010122.A30357@unix-os.sc.intel.com> <44B62D9D.20303@hitachi.com> <20060714112627.A15658@unix-os.sc.intel.com> In-Reply-To: <20060714112627.A15658@unix-os.sc.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q3/txt/msg00112.txt.bz2 Hi, Anil Keshavamurthy Anil S wrote: > --Comment here please > /* Booster probe is not support for preemptable kernel */ >> +#ifdef CONFIG_PREEMPT > ^^^^^^ Should be #ifndef That's for sure, I fixed it. >> + if (p->ainsn.boostable == 1 && !p->post_handler){ >> /* Boost up -- we can execute copied instructions directly */ >> reset_current_kprobe(); >> regs->eip = (unsigned long)p->ainsn.insn; >> preempt_enable_no_resched(); >> return 1; >> } >> +#endif >> prepare_singlestep(p, regs); >> kcb->kprobe_status = KPROBE_HIT_SS; >> return 1; > > Also you may want to do the same thing for kretprobe booster. I think the kretprobe booster is not affected by kernel preemption. Because all codes on the execution path of kretprobe-booster are the static assembly codes. These codes are never removed. > > Thanks, > Anil > > Thanks, -- Masami HIRAMATSU 2nd Research Dept. Hitachi, Ltd., Systems Development Laboratory E-mail: masami.hiramatsu.pt@hitachi.com