From: "Keshavamurthy, Anil S" <anil.s.keshavamurthy@intel.com>
To: "Jim Keniston" <jkenisto@us.ibm.com>, "Martin Hunt" <hunt@redhat.com>
Cc: "SystemTAP" <systemtap@sources.redhat.com>
Subject: RE: kprobe fault handling
Date: Tue, 07 Feb 2006 20:36:00 -0000 [thread overview]
Message-ID: <44BDAFB888F59F408FAE3CC35AB4704102F4F1A3@orsmsx409> (raw)
>I just had a long chat with Richard Moore about this whole topic. I
>agree with you on this, and I think Richard would, too.
>
>So unless there's a user-specified handler and that handler specifies
>(by returning 1) that it has handled the exception,
>kprobe_fault_handler() should run fixup_exception(), right?
>
>Now I'm looking, later in that function, at the code (on i386) where we
>handle an exception while single-stepping. I don't think
>resume_execution() is the right thing to do here. We haven't
>successfully executed the probed instruction, and the eip still points
>at that instruction, right? I think we're just hosed at this point.
>Comments?
I agree with your comments and we need a better fix.
Currently for RHEL4 release I am inclined to remove
DIE_PAGE_FAULT switch case as this at least improves
the performance.
-Anil
next reply other threads:[~2006-02-07 20:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-07 20:36 Keshavamurthy, Anil S [this message]
2006-02-07 20:48 ` Martin Hunt
-- strict thread matches above, loose matches on Subject: below --
2006-02-09 8:55 Mao, Bibo
2006-02-09 10:22 ` Richard J Moore
2006-02-07 22:19 Keshavamurthy, Anil S
2006-02-06 19:49 Martin Hunt
2006-02-07 0:51 ` Jim Keniston
2006-02-07 17:31 ` Jim Keniston
2006-02-07 17:50 ` Martin Hunt
2006-02-07 19:49 ` Jim Keniston
2006-02-08 4:38 ` Suparna Bhattacharya
2006-02-08 11:32 ` Richard J Moore
2006-02-09 7:23 ` Prasanna S Panchamukhi
2006-02-09 16:33 ` Keshavamurthy Anil S
2006-02-09 21:35 ` Jim Keniston
2006-02-09 22:06 ` Martin Hunt
2006-02-10 5:39 ` Martin Hunt
2006-02-10 21:46 ` Frank Ch. Eigler
2006-02-10 21:55 ` Martin Hunt
2006-02-10 22:12 ` Frank Ch. Eigler
2006-02-10 22:17 ` Martin Hunt
2006-02-10 22:20 ` Frank Ch. Eigler
2006-02-10 22:41 ` Martin Hunt
2006-02-10 22:47 ` Frank Ch. Eigler
2006-02-10 23:36 ` Martin Hunt
2006-02-11 0:49 ` Frank Ch. Eigler
2006-02-12 1:26 ` Martin Hunt
2006-02-13 13:39 ` Frank Ch. Eigler
2005-09-06 12:56 Prasanna S Panchamukhi
2005-09-06 15:09 ` Frank Ch. Eigler
2005-09-08 11:52 ` Prasanna S Panchamukhi
2005-09-08 17:42 ` Frank Ch. Eigler
2005-09-06 1:06 Frank Ch. Eigler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44BDAFB888F59F408FAE3CC35AB4704102F4F1A3@orsmsx409 \
--to=anil.s.keshavamurthy@intel.com \
--cc=hunt@redhat.com \
--cc=jkenisto@us.ibm.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).