public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "Keshavamurthy, Anil S" <anil.s.keshavamurthy@intel.com>
To: <prasanna@in.ibm.com>
Cc: <systemtap@sources.redhat.com>
Subject: RE: [PATCH] Kprobes- robust fault handling for i386
Date: Fri, 24 Feb 2006 19:17:00 -0000	[thread overview]
Message-ID: <44BDAFB888F59F408FAE3CC35AB470410313D68D@orsmsx409> (raw)

Prasanna,
	For better review comments, can you please split your patch
into following, currently finding it hard to follow the kprobes states.
1) [PATCH]Fault handling due to calling pre_handler
2) [PATCH]Fault handling due to calling post_handler
3) [PATCH]Fault handling due to single_stepping
4) [PATCH]Fault handling due to single_stepping reentrant probe

Patches 3 and 4 above are required only to support user probes,
so for now I think you can skip them.

Also another suggesting, rename the kprobes states to something more
meaning full. Say
KPROBE_IN_PRE_HANDLER - This states indicates we are calling pre_handler
KPROBE_IN_POST_HANDLER - This states indicates we are calling
post_handler
KPROBES_IN_SS - We are trying to single step
KPROBES_IN_REENTER_SS - We are trying to single step reentrant probes 
[...]


Thanks,
-Anil Keshavamurthy

             reply	other threads:[~2006-02-24 19:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-24 19:17 Keshavamurthy, Anil S [this message]
2006-02-27  9:24 ` Prasanna S Panchamukhi
2006-02-27  9:25   ` [PATCH] Kprobes- robust fault handling for i386 post_handler changes Prasanna S Panchamukhi
2006-02-28  1:02   ` [PATCH] Kprobes- robust fault handling for i386 Keshavamurthy Anil S
2006-02-28 14:37     ` Prasanna S Panchamukhi
2006-02-28 20:25       ` Keshavamurthy Anil S
2006-03-01 14:49         ` Prasanna S Panchamukhi
  -- strict thread matches above, loose matches on Subject: below --
2006-02-23  0:44 Keshavamurthy, Anil S
2006-02-22 10:41 Mao, Bibo
2006-02-23  8:58 ` Prasanna S Panchamukhi
2006-02-23 12:40   ` Frank Ch. Eigler
2006-02-23 13:17     ` Prasanna S Panchamukhi
2006-02-22  7:11 Prasanna S Panchamukhi
2006-02-24  1:33 ` Jim Keniston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44BDAFB888F59F408FAE3CC35AB470410313D68D@orsmsx409 \
    --to=anil.s.keshavamurthy@intel.com \
    --cc=prasanna@in.ibm.com \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).