From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31829 invoked by alias); 24 Feb 2006 19:17:09 -0000 Received: (qmail 31820 invoked by uid 22791); 24 Feb 2006 19:17:09 -0000 X-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from fmr19.intel.com (HELO orsfmr004.jf.intel.com) (134.134.136.18) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 24 Feb 2006 19:17:07 +0000 Received: from orsfmr101.jf.intel.com (orsfmr101.jf.intel.com [10.7.209.17]) by orsfmr004.jf.intel.com (8.12.10/8.12.10/d: major-outer.mc,v 1.1 2004/09/17 17:50:56 root Exp $) with ESMTP id k1OJH2Se020364; Fri, 24 Feb 2006 19:17:02 GMT Received: from orsmsxvs041.jf.intel.com (orsmsxvs041.jf.intel.com [192.168.65.54]) by orsfmr101.jf.intel.com (8.12.10/8.12.10/d: major-inner.mc,v 1.2 2004/09/17 18:05:01 root Exp $) with SMTP id k1OJH1Wn015561; Fri, 24 Feb 2006 19:17:02 GMT Received: from orsmsx332.amr.corp.intel.com ([192.168.65.60]) by orsmsxvs041.jf.intel.com (SAVSMTP 3.1.7.47) with SMTP id M2006022411170211113 ; Fri, 24 Feb 2006 11:17:02 -0800 Received: from orsmsx409.amr.corp.intel.com ([192.168.65.58]) by orsmsx332.amr.corp.intel.com with Microsoft SMTPSVC(6.0.3790.211); Fri, 24 Feb 2006 11:17:02 -0800 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Subject: RE: [PATCH] Kprobes- robust fault handling for i386 Date: Fri, 24 Feb 2006 19:17:00 -0000 Message-ID: <44BDAFB888F59F408FAE3CC35AB470410313D68D@orsmsx409> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [PATCH] Kprobes- robust fault handling for i386 Thread-Index: AcY4V3lOQ/5pHYBnTF65yyjB/kJ0dwBHoHcA From: "Keshavamurthy, Anil S" To: Cc: X-OriginalArrivalTime: 24 Feb 2006 19:17:02.0472 (UTC) FILETIME=[E43C5080:01C63976] X-Scanned-By: MIMEDefang 2.52 on 10.7.209.17 X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q1/txt/msg00625.txt.bz2 Prasanna, For better review comments, can you please split your patch into following, currently finding it hard to follow the kprobes states. 1) [PATCH]Fault handling due to calling pre_handler 2) [PATCH]Fault handling due to calling post_handler 3) [PATCH]Fault handling due to single_stepping 4) [PATCH]Fault handling due to single_stepping reentrant probe Patches 3 and 4 above are required only to support user probes, so for now I think you can skip them. Also another suggesting, rename the kprobes states to something more meaning full. Say KPROBE_IN_PRE_HANDLER - This states indicates we are calling pre_handler KPROBE_IN_POST_HANDLER - This states indicates we are calling post_handler KPROBES_IN_SS - We are trying to single step KPROBES_IN_REENTER_SS - We are trying to single step reentrant probes=20 [...] Thanks, -Anil Keshavamurthy