public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "bibo,mao" <bibo.mao@intel.com>
To: systemtap@sourceware.org
Subject: [PATCH]_stp_free_percpu function definition responding to _stp_alloc_percpu
Date: Mon, 16 Oct 2006 11:08:00 -0000	[thread overview]
Message-ID: <453367F6.8060505@intel.com> (raw)

Hi,
   On the newest 2.6.19-rc2 smp machines, stap fails to run. It
is because _stp_free_percpu is defined as free_percpu macro and
one function at the same time. This patch modifies this, and
replaces for_each_cpu with for_each_possible_cpu macro.

thanks
bibo,mao

--- src.org/runtime/alloc.c	2006-01-25 18:08:47.000000000 +0800
+++ src/runtime/alloc.c	2006-10-16 18:17:40.000000000 +0800
@@ -18,14 +18,9 @@
  #define kmalloc_node(size,flags,node) kmalloc(size,flags)
  #endif /* LINUX_VERSION_CODE */

-#ifdef CONFIG_SMP
-#define _stp_free_percpu(ptr) free_percpu(ptr)
-#else
-#define _stp_free_percpu(ptr) kfree(ptr)
-#endif
-
  #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,15)
  #define _stp_alloc_percpu(size) __alloc_percpu(size, 8)
+#define _stp_free_percpu(ptr) free_percpu(ptr)
  #else
  #ifdef CONFIG_SMP
  /* This is like alloc_percpu() except it simply takes a size, instead 
of a type. */
@@ -37,7 +32,7 @@ void *_stp_alloc_percpu(size_t size)
  	if (!pdata)
  		return NULL;

-	for_each_cpu(i) {
+	for_each_possible_cpu(i) {
  		int node = cpu_to_node(i);

  		if (node_online(node))
@@ -68,7 +63,7 @@ void _stp_free_percpu(const void *objp)
  	int i;
  	struct percpu_data *p = (struct percpu_data *) (~(unsigned long) objp);

-	for_each_cpu(i)
+	for_each_possible_cpu(i)
  		kfree(p->ptrs[i]);
  	kfree(p);
  }
@@ -80,6 +75,7 @@ void *_stp_alloc_percpu(size_t size)
                  memset(ret, 0, size);
          return ret;
  }
+#define _stp_free_percpu(ptr) kfree(ptr)
  #endif /* CONFIG_SMP */
  #endif /* LINUX_VERSION_CODE */
  #endif /* _ALLOC_C_ */

             reply	other threads:[~2006-10-16 11:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-16 11:08 bibo,mao [this message]
2006-10-18  0:05 Keshavamurthy, Anil S
2006-10-18  4:09 ` bibo,mao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=453367F6.8060505@intel.com \
    --to=bibo.mao@intel.com \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).