From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28502 invoked by alias); 20 Oct 2006 13:50:27 -0000 Received: (qmail 28495 invoked by uid 22791); 20 Oct 2006 13:50:26 -0000 X-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 20 Oct 2006 13:50:18 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k9KDoGkn020574; Fri, 20 Oct 2006 09:50:16 -0400 Received: from pobox.hsv.redhat.com (pobox.hsv.redhat.com [172.16.16.12]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id k9KDoFv2030806; Fri, 20 Oct 2006 09:50:16 -0400 Received: from [172.16.17.170] (dhcp-170.hsv.redhat.com [172.16.17.170]) by pobox.hsv.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id k9KDoE7M010596; Fri, 20 Oct 2006 09:50:15 -0400 Message-ID: <4538D41A.8030104@redhat.com> Date: Fri, 20 Oct 2006 13:50:00 -0000 From: David Smith User-Agent: Thunderbird 1.5.0.7 (X11/20061004) MIME-Version: 1.0 To: "Frank Ch. Eigler" CC: systemtap@sources.redhat.com Subject: Re: precompiled probing scenarios References: <20061006190806.GA30553@elastic.org> <4526BD8F.3060002@redhat.com> <20061006204001.GB4529@elastic.org> <4537D6D3.9000900@redhat.com> <20061019215319.GB17981@elastic.org> In-Reply-To: <20061019215319.GB17981@elastic.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q4/txt/msg00215.txt.bz2 Frank Ch. Eigler wrote: > Hi - > > dsmith wrote: > >> [...] > > Nice work, thank you! You might want to taunt people with some speed > improvement numbers too. Oops, I forgot to include those. For "make check", the time goes from 29 minutes (when seeding the cache) down to 8 minutes (with cache). For "make installcheck", the time goes from 56 minutes down to 24 minutes. >> [...] The hash is computed using the following data: >> - gcc's path, size, and mtime >> - stap's version and compile date > > In addition or instead of this, could include a hash of /proc/self/exe > content and/or stat info (like gcc's), for us developers. OK. >> [...] >> Note that currently several tests in the testsuite fail after a first >> run to seed the cache because they don't expect to see the skip from >> pass 2 to pass 5. > > How do you mean they fail? -p3 or -p4 should still work. Here's what goes on. The '-p3' and '-p4' options still work. But, several run ('-p5') tests use testsuite/lib/stap_run.exp or testsuite/lib/stap_run2.exp. Those two tcl files expect to see "Pass [12345]" in the output. They get confused when only seeing "Pass [125]" and then think the test has timed out. I'm hoping to fix this today. >> [...] >> - Set a maximum cache size and expire old modules. Is this needed? > > We can include a shell script ditty for that. I wouldn't bother put > the logic into stap proper. OK. > Regarding the choice of cache directory name (".stap_cache"), that's > OK if we don't anticipate anything other than cache files to have to > live under $HOME. But if we want to undertake cross-instrumentation > along the lines I proposed, we'd need at least a few more non-cache > files (for host descriptions for example). If so, then .stap_cache > should be nested as .systemtap/cache instead, so that other data files > may live under .systemtap/. That sounds reasonable. -- David Smith dsmith@redhat.com Red Hat http://www.redhat.com 256.217.0141 (direct) 256.837.0057 (fax)