From: Mike Mason <mmlnx@us.ibm.com>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: systemtap@sources.redhat.com
Subject: Re: marking tapset files
Date: Fri, 27 Oct 2006 15:14:00 -0000 [thread overview]
Message-ID: <45422243.2060007@us.ibm.com> (raw)
In-Reply-To: <20061027132033.GI4978@redhat.com>
I like the idea of adding the comment. Mechanical enforcement would be even better. Perhaps a keyword at the top of the file that marks it as part of a specific tapset. Then stap could print a clearer error message if someone tries to run it directly. For example, if tapset "foo" is comprised of three files, then each of those files could contain "tapset foo" near the top. This would also make it clearer which files are part of multi-file tapsets.
- Mike
Frank Ch. Eigler wrote:
> Hi -
>
> If you recall, scripts located under tapset/* are like libraries and
> not mainline scripts people can run individually. This confusion is
> biting several people. Short of some sort of mechanical enforcement,
> do you think it would be worthwhile to put an additional header comment
> into all our tapsets, near the copyright header (which they all should
> have, hint hint):
>
> /* This file is part of the tapset library. It is not meant for
> direct execution, but only for implicit use by other scripts.
> See test case <FILE> for an example. */
>
> - FChE
next prev parent reply other threads:[~2006-10-27 15:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-27 13:20 Frank Ch. Eigler
2006-10-27 15:14 ` Mike Mason [this message]
2006-10-27 15:34 ` Frank Ch. Eigler
2006-10-27 16:30 ` Vara Prasad
2006-11-15 20:05 ` Vara Prasad
2006-11-15 20:27 ` Frank Ch. Eigler
2006-12-04 22:16 ` Vara Prasad
2006-12-05 0:07 ` Frank Ch. Eigler
2006-12-05 1:34 ` Vara Prasad
2006-10-27 15:33 ` Vara Prasad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45422243.2060007@us.ibm.com \
--to=mmlnx@us.ibm.com \
--cc=fche@redhat.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).