From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9869 invoked by alias); 27 Oct 2006 16:30:46 -0000 Received: (qmail 9856 invoked by uid 22791); 27 Oct 2006 16:30:45 -0000 X-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from e5.ny.us.ibm.com (HELO e5.ny.us.ibm.com) (32.97.182.145) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 27 Oct 2006 16:30:40 +0000 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e5.ny.us.ibm.com (8.13.8/8.12.11) with ESMTP id k9RGUYUA024551 for ; Fri, 27 Oct 2006 12:30:34 -0400 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.6/8.13.6/NCO v8.1.1) with ESMTP id k9RGUKco085532 for ; Fri, 27 Oct 2006 12:30:21 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id k9RGUJ8N004421 for ; Fri, 27 Oct 2006 12:30:19 -0400 Received: from [127.0.0.1] (sig-9-65-5-156.mts.ibm.com [9.65.5.156]) by d01av02.pok.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id k9RGUEmv003900; Fri, 27 Oct 2006 12:30:18 -0400 Message-ID: <45423412.7010105@us.ibm.com> Date: Fri, 27 Oct 2006 16:30:00 -0000 From: Vara Prasad User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040804 Netscape/7.2 (ax) X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Frank Ch. Eigler" CC: Mike Mason , systemtap@sources.redhat.com Subject: Re: marking tapset files References: <20061027132033.GI4978@redhat.com> <45422243.2060007@us.ibm.com> <20061027153442.GJ4978@redhat.com> In-Reply-To: <20061027153442.GJ4978@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q4/txt/msg00263.txt.bz2 Frank Ch. Eigler wrote: >Hi - > > >On Fri, Oct 27, 2006 at 08:14:11AM -0700, Mike Mason wrote: > > >>I like the idea of adding the comment. Mechanical enforcement would be >>even better. Perhaps a keyword at the top of the file that marks it as >>part of a specific tapset. [...] >> >> > >That's a possibility. Short of language extensions though, the >translator could parse the tapset scripts first, then warn about >duplication. Heck, it could even track the visited dev/inode pairs in >struct stapfile, and know if the same file has been seen twice. > >- FChE > > Yes, translator can find out if same file is visted twice but with that can we give a meaningful error message to the user. I think what is needed here is when someone tries to execute a tapset they should gate message saying you can not execute a tapset library directly, similar to an error message given if we execute a library file. It would be even better if we can do something with our naming so that users can say the difference between the library and the end user script and avoid doing that mistake in the first place.