From: William Cohen <wcohen@redhat.com>
To: SystemTAP <systemtap@sources.redhat.com>
Subject: Reviewing Tapset code
Date: Wed, 30 May 2007 15:20:00 -0000 [thread overview]
Message-ID: <465D9640.5080001@redhat.com> (raw)
Currently we don't have a good idea of the amount of code in the tapset library
is exercised by the testsuite. There is a bugzilla entry for work related to
this, 4529, which I have on my action item list.
I did some simple command line to get an idea of the size of the tapsets and the
amount of guru mode used.
There is about 25K lines (including comments and blank lines) in the 57 .stp
files with about 356 probes/functions using guru mode in 49 files.
A significant amount of code is in the LKET directory, 7.2K lines. All of the
LKET files have guru mode code in them, because _lket_trace is implemented as a
C define, so each function that is tracing needs to use _lket_trace and is in
guru mode. The lket_trace define uses varargs, and need to be check to make sure
that the arguments agree.
LKET/lket_trace:update_record() changes internal systemtap data structure,
Stp_pbuf. It really shouldn't be doing that.
In LKET hookid_defs.stp a lot of the verbosity could be remove by using global
initializers rather than declaring the variable in one place and then
initializing it in hookid_init(). Something like the following:
global HOOKID_NFSD_PROBE_CREATE_RETURN = 38
-Will
reply other threads:[~2007-05-30 15:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=465D9640.5080001@redhat.com \
--to=wcohen@redhat.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).