Re: ARM port of testsuite and general testsuite fixes

[David Smith <dsmith@redhat.com>]

Quentin Barnes wrote:
> On Wed, Jun 06, 2007 at 03:07:26PM -0500, David Smith wrote:
>> Quentin Barnes wrote:
 >
>> I'm unsure as why you aren't getting the full information.
> 
> Ah, ha!  I do now.  It's another expect test script bug.  It is
> missing its timeout parameter.  (Patch below log output.)  Still
> the same six failures though.  Here's the output from cache.exp
> after adding the timeout patch:
> =====
> Running /usr/src/systemtap-20070602/testsuite/systemtap.base/cache.exp ...
> Pass 1: parsed user script and 53 library script(s) in 
> 8400usr/9330sys/17801real ms.^M
> Pass 2: analyzed script: 1 probe(s), 0 function(s), 0 embed(s), 0 
> global(s) in 120usr/140sys/261real ms.^M
> Pass 3: translated to C into 
> "/tmp/stapf82Z9z/stap_ea86208e9a0e159926d52fe9d08590cf_132.c" in 
> 0usr/30sys/53real ms.^M
> PASS: BASIC1 wasn't cached
> Pass 1: parsed user script and 53 library script(s) in 
> 8550usr/8770sys/17322real ms.^M
> Pass 2: analyzed script: 1 probe(s), 0 function(s), 0 embed(s), 0 
> global(s) in 170usr/60sys/222real ms.^M
> Pass 3: translated to C into 
> "/tmp/stapUl2TCg/stap_ea86208e9a0e159926d52fe9d08590cf_132.c" in 
> 0usr/30sys/35real ms.^M
> FAIL: BASIC2 wasn't cached

Well, you've improved things, but you're still missing the "Pass 4" 
output line.

As to what we *can* see, something odd is going on.  BASIC1 just tests 
that the first compile of a script isn't cached.  So far so good in your 
  output.  BASIC2 compiles the same script, expecting it to be cached. 
Yours wasn't (since the Pass 3 line didn't say "using cached").

Let's try some simple tests by hand.  Here's what I get when I compile 
the same simple script twice:

# stap -v -p4 -e 'probe begin { log("hello") }'
Pass 1: parsed user script and 54 library script(s) in 
520usr/20sys/542real ms.
Pass 2: analyzed script: 1 probe(s), 1 function(s), 0 embed(s), 0 
global(s) in 10usr/0sys/11real ms.
Pass 3: translated to C into 
"/tmp/stapHTajTu/stap_18fff0808dbc7fac961586069aa96877_233.c" in 
0usr/0sys/1real ms.
/home/dsmith/.systemtap/cache/18/stap_18fff0808dbc7fac961586069aa96877_233.ko
Pass 4: compiled C into "stap_18fff0808dbc7fac961586069aa96877_233.ko" 
in 3090usr/810sys/3770real ms.
# stap -v -p4 -e 'probe begin { log("hello") }'
Pass 1: parsed user script and 54 library script(s) in 
510usr/20sys/536real ms.
Pass 2: analyzed script: 1 probe(s), 1 function(s), 0 embed(s), 0 
global(s) in 10usr/0sys/11real ms.
/home/dsmith/.systemtap/cache/18/stap_18fff0808dbc7fac961586069aa96877_233.ko
Pass 3: using cached 
/home/dsmith/.systemtap/cache/18/stap_18fff0808dbc7fac961586069aa96877_233.c
Pass 4: using cached 
/home/dsmith/.systemtap/cache/18/stap_18fff0808dbc7fac961586069aa96877_233.ko

-- 
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)