From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8046 invoked by alias); 6 Jun 2007 21:51:48 -0000 Received: (qmail 8033 invoked by uid 22791); 6 Jun 2007 21:51:47 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,FORGED_RCVD_HELO,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 06 Jun 2007 21:51:44 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l56LpgVR032692; Wed, 6 Jun 2007 17:51:42 -0400 Received: from pobox.hsv.redhat.com (pobox.hsv.redhat.com [172.16.16.12]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l56Lpfiv003160; Wed, 6 Jun 2007 17:51:41 -0400 Received: from localhost.localdomain (dhcp-170.hsv.redhat.com [172.16.17.170]) by pobox.hsv.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id l56LpeOh020963; Wed, 6 Jun 2007 17:51:41 -0400 Message-ID: <46672C6C.6070007@redhat.com> Date: Wed, 06 Jun 2007 21:51:00 -0000 From: David Smith User-Agent: Thunderbird 2.0.0.0 (X11/20070419) MIME-Version: 1.0 To: Quentin Barnes CC: systemtap@sources.redhat.com Subject: Re: ARM port of testsuite and general testsuite fixes References: <20070606003646.GB20115@urbana.css.mot.com> <4666DA5D.3060403@redhat.com> <20070606171138.GC20115@urbana.css.mot.com> <4666FB5D.6070404@redhat.com> <20070606192537.GD20115@urbana.css.mot.com> <46671023.2060305@redhat.com> <20070606200049.GE20115@urbana.css.mot.com> <466713FE.1050804@redhat.com> <20070606203920.GF20115@urbana.css.mot.com> <466720A2.4070709@redhat.com> <20070606213541.GG20115@urbana.css.mot.com> In-Reply-To: <20070606213541.GG20115@urbana.css.mot.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2007-q2/txt/msg00497.txt.bz2 Quentin Barnes wrote: >> Well, you've improved things, but you're still missing the "Pass 4" >> output line. > > That's because of another bug in the expect script. (I've fixed a > dozen of these bugs now so I'm rather disappointed with myself that > I missed this one until now.) Great! I'm glad you fixed it. > As an aside, any reason that spaces are escaped in these regular > expressions? I didn't change it in this patch, but why are the > regular expressions written like this: > -re {^Pass\ [1234]:[^\r]*\ in\ [^\r]*\ ms\.\r\n} {exp_continue} > -re {^Pass\ [34]: using cached [^\r\n]+\r\n} {incr cached 1; exp_continue} > > And not like this?: > -re {^Pass [1234]:[^\r]* in [^\r]* ms\.\r\n} {exp_continue} > -re {^Pass [34]: using cached [^\r\n]+\r\n} {incr cached 1; exp_continue} Good question. I believe it is to work around an expect bug - someone else might remember the details. -- David Smith dsmith@redhat.com Red Hat http://www.redhat.com 256.217.0141 (direct) 256.837.0057 (fax)