From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20683 invoked by alias); 20 Aug 2007 05:12:52 -0000 Received: (qmail 20390 invoked by uid 22791); 20 Aug 2007 05:12:51 -0000 X-Spam-Status: No, hits=2.7 required=5.0 tests=AWL,BAYES_40,DK_POLICY_SIGNSOME,UNPARSEABLE_RELAY X-Spam-Check-By: sourceware.org Received: from mail9.hitachi.co.jp (HELO mail9.hitachi.co.jp) (133.145.228.44) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 20 Aug 2007 05:12:31 +0000 Received: from mlsv5.hitachi.co.jp (unknown [133.144.234.166]) by mail9.hitachi.co.jp (Postfix) with ESMTP id 4C9CD37C8F for ; Mon, 20 Aug 2007 14:12:28 +0900 (JST) Received: from mfilter-s5.hitachi.co.jp by mlsv5.hitachi.co.jp (8.12.10/8.12.10) id l7K5CSLC031302; Mon, 20 Aug 2007 14:12:28 +0900 Received: from vshuts1.hitachi.co.jp (unverified) by mfilter-s5.hitachi.co.jp (Content Technologies SMTPRS 4.3.17) with SMTP id ; Mon, 20 Aug 2007 14:12:27 +0900 Received: from hsdlgw92.sdl.hitachi.co.jp ([133.144.7.20]) by vshuts1.hitachi.co.jp with SMTP id M2007082014122727857 ; Mon, 20 Aug 2007 14:12:27 +0900 Received: from vgate2.sdl.hitachi.co.jp by hsdlgw92.sdl.hitachi.co.jp (8.13.1/3.7W06092911) id l7K5CRcb030242; Mon, 20 Aug 2007 14:12:27 +0900 Received: from sdl99w.sdl.hitachi.co.jp ([133.144.14.250]) by vgate2.sdl.hitachi.co.jp (SAVSMTP 3.1.1.32) with SMTP id M2007082014122629790 ; Mon, 20 Aug 2007 14:12:26 +0900 Received: from hitachi.com (IDENT:U2FsdGVkX197NESu3IdRyuxcPgxspPhcaCngXe+YovU@localhost.localdomain [127.0.0.1]) by sdl99w.sdl.hitachi.co.jp (8.13.1/3.7W04031011) with ESMTP id l7K5CISq030575; Mon, 20 Aug 2007 14:12:18 +0900 Message-ID: <46C92209.90608@hitachi.com> Date: Mon, 20 Aug 2007 13:42:00 -0000 From: Satoru MORIYA User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja-JP; rv:1.4) Gecko/20030624 Netscape/7.1 (ax) X-Accept-Language: ja MIME-Version: 1.0 To: "Discussion list for crash utility usage, maintenance and development" Cc: yumiko.sugita.yf@hitachi.com, systemtap@sources.redhat.com Subject: Re: [Crash-utility] Re: [RFC] Crash extension for SystemTap References: <46542938.3070502@hitachi.com> <4654E1F4.2030107@hitachi.com> <4655A59E.40102@redhat.com> <467BD175.6050303@hitachi.com> In-Reply-To: Content-Type: multipart/mixed; boundary="------------090009060707060103070202" X-Virus-Checked: Checked by ClamAV on sourceware.org X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2007-q3/txt/msg00394.txt.bz2 This is a multi-part message in MIME format. --------------090009060707060103070202 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1142 Hi Frank, Thank you for including the crash extension in systemtap tree. And I'm sorry for delaying my reply for a long time. > [...]I could not make it print data from a crash session running > against the live kernel [...] I'm Sorry, I didn't test my crash extension on x86_64. Now I tested it on x86_64 and fixed bugs, so I think you can use it on x86_64 architecture. Changes: - fix the way of calculating the offset of rchan in struct utt_trace - fix the type of padding value in output_cpu_logs() - fix the console messages - don't make a directory and files if there's no data in relay buffer I have tested this extention on the following systems: * FC7,i386,kernel-2.6.22,systemtap-0.5.15,crash-4.0-4.5 * FC7,x86_64,kernel-2.6.21-1.3194.fc7,systemtap-0.5.15,crash-4.0-4.5 * FC7,x86_64,kernel-2.6.21-1.3194.fc7debug,systemtap-0.5.15,crash-4.0-4.5 * RHEL5,i386,kernel-2.6.18-8.el5,systemtap-0.5.15,crash-4.0-4.5 * RHEL5,ia64,kernel-2.6.18-8.el5,systemtap-0.5.15,crash-4.0-4.5 Best regards, -- --- Satoru MORIYA Linux Technology Center Hitachi, Ltd., Systems Development Laboratory E-mail: satoru.moriya.br@hitachi.com --------------090009060707060103070202 Content-Type: text/plain; name="staplog_fix.patch" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="staplog_fix.patch" Content-length: 6527 SW5kZXg6IHN5c3RlbXRhcC9zdGFwbG9nLmMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gc3lzdGVtdGFwLm9yaWcvc3RhcGxvZy5jCisrKyBzeXN0ZW10 YXAvc3RhcGxvZy5jCkBAIC00OCw5ICs0OCw2IEBACiAKICNpbmNsdWRlIDxj cmFzaC9kZWZzLmg+CiAKLSNkZWZpbmUgU1RQTE9HX05PX01PRCAgLTEKLSNk ZWZpbmUgU1RQTE9HX05PX1NZTSAgLTIKLQogc3RydWN0IHJjaGFuX29mZnNl dHMgewogCWxvbmcJc3ViYnVmX3NpemU7CiAJbG9uZwluX3N1YmJ1ZnM7CkBA IC0xNjcsMTAgKzE2NCwzNSBAQCBzdGF0aWMgdm9pZCBnZXRfcmNoYW5fYnVm KGludCBjcHUsIHVsb25nCiBzdGF0aWMgdWxvbmcgZ2V0X3JjaGFuX2FkZHIo dWxvbmcgc3RwX3V0dF9hZGRyKQogewogCXVsb25nIHN0cF91dHQ7CisJbG9u ZyBvZmZzZXQ7CiAKIAlyZWFkbWVtKHN0cF91dHRfYWRkciwgS1ZBRERSLCAm c3RwX3V0dCwgc2l6ZW9mKHZvaWQqKSwKIAkJInN0cF91dHQiLCBGQVVMVF9P Tl9FUlJPUik7Ci0JcmV0dXJuIChzdHBfdXR0ICsgc2l6ZW9mKGludCkpOwor CisJLyoKKwkgKiBJZiB3ZSBjb3VsZG4ndCBnZXQgdGhlIG1lbWJlciBvZmZz ZXQgb2Ygc3RydWN0IHV0dF90cmFjZS5yY2hhbiwKKwkgKiBpLmUuIHRoZSBk ZWJ1Z2luZm8gb2YgdGhlIHRyYWNlIG1vZHVsZSBpc24ndCBhdmFpbGFibGUs IHdlIHVzZQorCSAqIHNpemVvZihsb25nKSBhcyB0aGUgb2Zmc2V0IGluc3Rl YWQuIEN1cnJlbnRseSBzdHJ1Y3QgdXR0X3RyYWNlCisJICogaXMgZGVmaW5l ZCBhcyBiZWxvdzoKKwkgKgorCSAqICAgICBzdHJ1Y3QgdXR0X3RyYWNlIHsK KwkgKiAgICAgICAgICAgICBpbnQgdHJhY2Vfc3RhdGU7CisJICogICAgICAg ICAgICAgc3RydWN0IHJjaGFuICpyY2hhbjsKKwkgKiAgICAgICAgICAgICAu Li4KKwkgKiAgICAgfQorCSAqCisJICogQWx0aG91Z2ggdGhlIHR5cGUgb2Yg dGhlIHByZWNlZGluZyBtZW1iZXIgaXMgaW50LCBzaXplb2YobG9uZykKKwkg KiBpcyBPSywgYmVjYXVzZSByY2hhbiBpcyBhbGlnbmVkIHdpdGggbG9uZyBz aXplIG9uIGJvdGggMzItYml0CisJICogYW5kIDY0LWJpdCBlbnZpcm9ubWVu dC4gV2hlbiB0aGUgZGVmaW5pc2lvbiBvZiBzdHJ1Y3QgdXR0X3RyYWNlCisJ ICogY2hhbmdlZCwgd2UgbXVzdCBjaGVjayBpZiB0aGlzIGNvZGUgaXMgY29y cmVjdC4KKwkgKi8KKwlpZiAoKG9mZnNldCA9IE1FTUJFUl9PRkZTRVQoInV0 dF90cmFjZSIsICJyY2hhbiIpKSA8IDApIHsKKwkJZXJyb3IoV0FSTklORywg IlRoZSBkZWJ1Z2luZm8gb2YgdGhlIHRyYWNlIG1vZHVsZSBoYXNuJ3QgYmVl biBsb2FkZWQuICIKKwkJICAgICAgIllvdSBtYXkgbm90IGJlIGFibGUgdG8g cmV0cmlldmUgdGhlIGNvcnJlY3QgdHJhY2UgZGF0YS5cbiIpOworCQlvZmZz ZXQgPSBzaXplb2YobG9uZyk7CisJfQorCisJcmV0dXJuIChzdHBfdXR0ICsg KHVsb25nKW9mZnNldCk7CiB9CiAKIHN0YXRpYyBpbnQgY2hlY2tfZ2xvYmFs X2J1ZmZlcih1bG9uZyByY2hhbikKQEAgLTIyMCwyNSArMjQyLDE1IEBAIHN0 YXRpYyB2b2lkIHNldHVwX2dsb2JhbF9kYXRhKGNoYXIgKm1vZHUKIAlyZXR1 cm47CiB9CiAKLXN0YXRpYyB2b2lkIG91dHB1dF9jcHVfbG9ncyhjaGFyICpm aWxlbmFtZSkKK3N0YXRpYyB2b2lkIG91dHB1dF9jcHVfbG9ncyhjaGFyICpk aXJuYW1lKQogewogCWludCBpLCBtYXggPSAyNTY7CiAJc3RydWN0IHBlcl9j cHVfZGF0YSAqcGNkOwogCXNpemVfdCBuLCBpZHgsIHN0YXJ0LCBlbmQsIHJl YWR5LCBsZW47Ci0JdW5zaWduZWQgcGFkZGluZzsKKwlzaXplX3QgcGFkZGlu ZzsKIAljaGFyIGZuYW1lW21heCArIDFdLCAqc291cmNlOwogCURJUiAqZGly OwogCi0JLyogY2hlY2sgYW5kIGNyZWF0ZSBsb2cgZGlyZWN0b3J5ICovCi0J ZGlyID0gb3BlbmRpcihmaWxlbmFtZSk7Ci0JaWYgKGRpcikgewotCQljbG9z ZWRpcihkaXIpOwotCX0gZWxzZSB7Ci0JCWlmIChta2RpcihmaWxlbmFtZSwg U19JUldYVSkgPCAwKSB7Ci0JCQllcnJvcihGQVRBTCwgImNhbm5vdCBjcmVh dGUgbG9nIGRpcmVjdG9yeSAnJXNcbiciLCBmaWxlbmFtZSk7Ci0JCX0KLQl9 Ci0KIAkvKiBhbGxvY2F0ZSBzdWJidWYgbWVtb3J5ICovCiAJc3ViYnVmID0g R0VUQlVGKGNoYW4uc3ViYnVmX3NpemUpOwogCWlmICghc3ViYnVmKSB7CkBA IC0yNTcsNiArMjY5LDE1IEBAIHN0YXRpYyB2b2lkIG91dHB1dF9jcHVfbG9n cyhjaGFyICpmaWxlbmEKIAkJCWFkanVzdCA9IDE7CiAJCX0KIAkJcmVhZHkg PSBwY2QtPmJ1Zi5zdWJidWZzX3Byb2R1Y2VkICsgYWRqdXN0OworCQlpZiAo cmVhZHkgPT0gMCkgeworCQkJaWYgKGlzX2dsb2JhbCA9PSAxKSB7CisJCQkJ ZXJyb3IoV0FSTklORywgIlRoZXJlIGlzIG5vIGRhdGEgaW4gdGhlIHJlbGF5 IGJ1ZmZlci5cbiIpOworCQkJCWJyZWFrOworCQkJfSBlbHNlIHsKKwkJCQll cnJvcihXQVJOSU5HLCAiW2NwdTolZF1UaGVyZSBpcyBubyBkYXRhIGluIHRo ZSByZWxheSBidWZmZXIuXG4iLCBpKTsKKwkJCQljb250aW51ZTsKKwkJCX0K KwkJfQogCiAJCWlmIChyZWFkeSA+IGNoYW4ubl9zdWJidWZzKSB7CiAJCQlz dGFydCA9IHJlYWR5OwpAQCAtMjY2LDEzICsyODcsMzAgQEAgc3RhdGljIHZv aWQgb3V0cHV0X2NwdV9sb2dzKGNoYXIgKmZpbGVuYQogCQkJZW5kID0gcmVh ZHk7CiAJCX0KIAkJLyogcHJpbnQgaW5mb3JtYXRpb24gKi8KLQkJZnByaW50 ZihmcCwgIi0tLSBnZW5lcmF0aW5nICdjcHUlZCcgLS0tXG4iLCBpKTsKKwkJ aWYgKGlzX2dsb2JhbCA9PSAxKSB7CisJCQlmcHJpbnRmKGZwLCAiLS0tIGdl bmVyYXRpbmcgJ2dsb2JhbCcgLS0tXG4iKTsKKwkJfSBlbHNlIHsKKwkJCWZw cmludGYoZnAsICItLS0gZ2VuZXJhdGluZyAnY3B1JWQnIC0tLVxuIiwgaSk7 CisJCX0KIAkJZnByaW50ZihmcCwgIiAgc3ViYnVmcyByZWFkeSBvbiByZWxh eWZzOiVsZFxuIiwgKGxvbmcpcmVhZHkpOwotCQlmcHJpbnRmKGZwLCAiICAg IG5fc3ViYnVmczolbGQsIHJlYWQgZnJvbTolbGQgdG86JWxkIChvZmZzZXQ6 JWxkKVxuXG4iLAotCQkJKGxvbmcpY2hhbi5uX3N1YmJ1ZnMsIChsb25nKXN0 YXJ0LCAobG9uZyllbmQsIChsb25nKXBjZC0+YnVmLm9mZnNldCk7Ci0KLQkJ LyogY3JlYXRlIGxvZyBmaWxlICovCi0JCXNucHJpbnRmKGZuYW1lLCBtYXgs ICIlcy9jcHUlZCIsIGZpbGVuYW1lLCBpKTsKKwkJZnByaW50ZihmcCwgIiAg bl9zdWJidWZzOiVsZCwgcmVhZCBmcm9tOiVsZCB0bzolbGQgKG9mZnNldDol bGQpXG5cbiIsCisJCQkobG9uZyljaGFuLm5fc3ViYnVmcywgKGxvbmcpKHN0 YXJ0ID8gc3RhcnQgLSBjaGFuLm5fc3ViYnVmcyA6IHN0YXJ0KSwKKwkJCShs b25nKShzdGFydCA/IGVuZCAtIDEgLSBjaGFuLm5fc3ViYnVmcyA6IGVuZCAt IDEpLCAobG9uZylwY2QtPmJ1Zi5vZmZzZXQpOworCisJCS8qIGNyZWF0ZSBs b2cgZGlyIGFuZCBmaWxlICovCisJCWRpciA9IG9wZW5kaXIoZGlybmFtZSk7 CisJCWlmIChkaXIpIHsKKwkJCWNsb3NlZGlyKGRpcik7CisJCX0gZWxzZSB7 CisJCQlpZiAobWtkaXIoZGlybmFtZSwgU19JUldYVSkgPCAwKSB7CisJCQkJ ZXJyb3IoRkFUQUwsICJjYW5ub3QgY3JlYXRlIGxvZyBkaXJlY3RvcnkgJyVz XG4nIiwgZGlybmFtZSk7CisJCQl9CisJCX0KKwkJaWYgKGlzX2dsb2JhbCA9 PSAxKSB7CisJCQlzbnByaW50ZihmbmFtZSwgbWF4LCAiJXMvZ2xvYmFsIiwg ZGlybmFtZSwgaSk7CisJCX0gZWxzZSB7CisJCQlzbnByaW50ZihmbmFtZSwg bWF4LCAiJXMvY3B1JWQiLCBkaXJuYW1lLCBpKTsKKwkJfQogCQlvdXRmcCA9 IGZvcGVuKGZuYW1lLCAidyIpOwogCQlpZiAoIW91dGZwKSB7CiAJCQllcnJv cihGQVRBTCwgImNhbm5vdCBjcmVhdGUgbG9nIGZpbGUgJyVzJ1xuIiwgZm5h bWUpOwpAQCAtMzE2LDEwICszNTQsMTAgQEAgc3RhdGljIHZvaWQgb3V0cHV0 X2NwdV9sb2dzKGNoYXIgKmZpbGVuYQogCXJldHVybjsKIH0KIAotc3RhdGlj IHZvaWQgZG9fc3RhcGxvZyhjaGFyICptb2R1bGUsIGNoYXIgKmZpbGVuYW1l KQorc3RhdGljIHZvaWQgZG9fc3RhcGxvZyhjaGFyICptb2R1bGUsIGNoYXIg KmRpcm5hbWUpCiB7CiAJc2V0dXBfZ2xvYmFsX2RhdGEobW9kdWxlKTsKLQlv dXRwdXRfY3B1X2xvZ3MoZmlsZW5hbWUpOworCW91dHB1dF9jcHVfbG9ncyhk aXJuYW1lKTsKIAlyZXR1cm47CiB9CiAKQEAgLTMyOCwxMiArMzY2LDEyIEBA IHZvaWQgY21kX3N0YXBsb2codm9pZCkKIAogCWludCBjOwogCWNoYXIgKm1v ZHVsZSA9IE5VTEw7Ci0JY2hhciAqZmlsZW5hbWUgPSBOVUxMOworCWNoYXIg KmRpcm5hbWUgPSBOVUxMOwogCiAJd2hpbGUgKChjID0gZ2V0b3B0KGFyZ2Nu dCwgYXJncywgIm86IikpICE9IEVPRikgewogCQlzd2l0Y2ggKGMpIHsKIAkJ Y2FzZSAnbyc6Ci0JCQlmaWxlbmFtZSA9IG9wdGFyZzsKKwkJCWRpcm5hbWUg PSBvcHRhcmc7CiAJCQlicmVhazsKIAkJZGVmYXVsdDoKIAkJCWFyZ2VycnMr KzsKQEAgLTM0NSw5ICszODMsOSBAQCB2b2lkIGNtZF9zdGFwbG9nKHZvaWQp CiAJaWYgKCFtb2R1bGUgfHwgYXJnZXJycykKIAkJY21kX3VzYWdlKHBjLT5j dXJjbWQsIFNZTk9QU0lTKTsKIAotCWlmIChmaWxlbmFtZSA9PSBOVUxMICYm IG1vZHVsZSAhPSBOVUxMKQotCQlmaWxlbmFtZSA9IG1vZHVsZTsKLQlkb19z dGFwbG9nKG1vZHVsZSwgZmlsZW5hbWUpOworCWlmIChkaXJuYW1lID09IE5V TEwgJiYgbW9kdWxlICE9IE5VTEwpCisJCWRpcm5hbWUgPSBtb2R1bGU7CisJ ZG9fc3RhcGxvZyhtb2R1bGUsIGRpcm5hbWUpOwogCXJldHVybjsKIH0KIAo= --------------090009060707060103070202--