Re: bug-fix reviews [was: Bug 4930]

[Vara Prasad <prasadav@us.ibm.com>]

Jim Keniston wrote:

>On Fri, 2007-09-14 at 08:08 -0700, Vara Prasad wrote:
>  
>
>>Wenji Huang wrote:
>>
>>    
>>
>>>Hi all,
>>>
>>>   Regarding to bug 4930, I created patches for it 
>>>(http://sources.redhat.com/bugzilla/show_bug.cgi?id=4930).
>>>   Please kindly review it. If no objection, I will commit it.
>>>
>>>Thanks,
>>>Wenji
>>>      
>>>
>>Can we follow/change our review process to that of kernel where patch is 
>>posted inline in the mailing list for review instead of posting/placing 
>>elsewhere? I am hoping having patches readily available in the mail 
>>client improves our review process and avoids costly mistakes.
>>
>>bye,
>>Vara Prasad
>>    
>>
>
>It's definitely appropriate to attach the patch to the bugzilla.  To get
>a review, you either need to ensure that appropriate reviewers are on
>the bugzilla's cc list, or explicitly request a review, as Wenji has
>done.  I don't find it inconvenient to follow a couple of links to get
>at the patch.
>
>I prefer to see review accomplished via the bugzilla mechanism, so that
>the thread is captured in the bugzilla.  Of course, this typically
>restricts visibility of the review thread to the bug owner and the
>bugzilla's cc list.  Pro: Uninterested people aren't bothered with
>extraneous emails.  Con: (a) A relevant reviewer may be excluded from
>the cc list.  (b) If the review thread forks off a thread that warrants
>wider participation, somebody has to take the trouble to move that
>thread out of the bugzilla.
>
>Jim
>
>  
>

Well, review comments thread can be accomplished via mailing list as 
well hence i don't see any advantage of doing it in the bugzilla. There 
are lot more people looking at the mailing list then just bugs and 
excluding them from the review to me is a big disadvantage. Coming to 
providing a link to bugzilla and asking for review still has the draw 
back of traversing the link. I think following the common open source 
methodology of reviewing the patches in the mailing list gives us better 
chance of good reviews and we don't have to ask developers to learn a 
new process.

bye,
Vara Prasad