From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30603 invoked by alias); 20 Nov 2007 18:57:03 -0000 Received: (qmail 30583 invoked by uid 22791); 20 Nov 2007 18:57:02 -0000 X-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,DK_POLICY_SIGNSOME,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 20 Nov 2007 18:56:51 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id lAKIunpS001518 for ; Tue, 20 Nov 2007 13:56:49 -0500 Received: from mail.boston.redhat.com (mail.boston.redhat.com [172.16.76.12]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lAKIum97011763; Tue, 20 Nov 2007 13:56:48 -0500 Received: from [172.16.83.2] (dhcp83-2.boston.redhat.com [172.16.83.2]) by mail.boston.redhat.com (8.13.1/8.13.1) with ESMTP id lAKIum3o003220; Tue, 20 Nov 2007 13:56:48 -0500 Message-ID: <47432DEF.6010609@redhat.com> Date: Tue, 20 Nov 2007 18:57:00 -0000 From: Masami Hiramatsu User-Agent: Thunderbird 2.0.0.9 (X11/20071115) MIME-Version: 1.0 To: "Frank Ch. Eigler" CC: systemtap@sources.redhat.com Subject: Re: [Bug translator/4935] support on-the-fly probe enable/disable syntax References: <20070817183537.4935.fche@redhat.com> <20071116234033.13586.qmail@sourceware.org> In-Reply-To: X-Enigmail-Version: 0.95.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2007-q4/txt/msg00376.txt.bz2 Hi, Frank Ch. Eigler wrote: > Hi - > >> I developed a patch for the parser and the elabolator to support >> this syntax. Currently, this just translates the next script; [...] >> This is the first step of this feature, since this patch does not >> include optimization code. > > It is a fine start. Please merge & commit it. Are you planning to > write some tests & documentation for this new syntax? Thanks, I'm writing some tests for this syntax and updating a manual. I think the most part of documents might be fixed after the optimization is implemented. > The optimization wor (automagic probe disable/enable operations) will > be much bigger, and we should share the work. Indeed. The arm/disarm-probe methods for each kind of probes are different. So I think we'd better implement it one by one. > > - FChE -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America) Inc. Software Solutions Division e-mail: mhiramat@redhat.com, masami.hiramatsu.pt@hitachi.com